Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-setup: rely on new virtualenv for venv creation in Ubuntu 22.04 #1402

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

RasmusWL
Copy link
Member

Removes the hotfix from #1257

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

Have not updated either, since this should not be a user visible change

@RasmusWL RasmusWL requested review from a team as code owners November 29, 2022 10:48
@RasmusWL
Copy link
Member Author

Forgot to link to the release notes of virtualenv: https://virtualenv.pypa.io/en/latest/changelog.html#bugfixes-20-16-6 -- this was actually fixed some time ago, but apparently my automation for noticing a new release only kicked in for a major release 🤷

Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up with the cleanup!

python-setup/install_tools.ps1 Show resolved Hide resolved
python-setup/install_tools.sh Show resolved Hide resolved
python-setup/install_tools.sh Show resolved Hide resolved
@RasmusWL RasmusWL merged commit 160613c into main Nov 29, 2022
@RasmusWL RasmusWL deleted the rasmuswl/new-virtualenv branch November 29, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants