Send the external repository token to the CLI #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
force-pushed
the
aeisenberg/externalRepoTokenConfigParsing
branch
5 times, most recently
from
b62c79e
to
c17dc61
Compare
This commit does a few related things: 1. Bumps the minimum version for cli config parsing to 2.10.6 2. Ensures that if cli config parsing is enabled, then remove repos are _not_ downloaded by the action. It happens in the CLI. 3. Passes the `--external-repository-token-stdin` option to the CLI and passes the appropriate token via stdin if cli config parsing is enabled.
aeisenberg
force-pushed
the
aeisenberg/externalRepoTokenConfigParsing
branch
from
c17dc61
to
4023575
Compare
|
Failing test is because the cached version of the cli is too old to be using cli config parsing now, so the cli config files are not generated. The test will start passing when the cached version becomes 2.11.6. |
|
@henrymercer, I think you are the one with the most background to review. Can you take a look? |
henrymercer
previously approved these changes
Jan 10, 2023
|
Failures due to using a kotlin version that is too new. Updating the base branch should fix it. |
henrymercer
approved these changes
Jan 10, 2023
This was referenced Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does a few related things:
are not downloaded by the action. It happens in the CLI.
--external-repository-token-stdinoption to the CLIand passes the appropriate token via stdin if cli config parsing is
enabled.
See the linked, internal PR for the integration test associated with this change.
Merge / deployment checklist