-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send the external repository token to the CLI #1464
Conversation
b62c79e
to
c17dc61
Compare
This commit does a few related things: 1. Bumps the minimum version for cli config parsing to 2.10.6 2. Ensures that if cli config parsing is enabled, then remove repos are _not_ downloaded by the action. It happens in the CLI. 3. Passes the `--external-repository-token-stdin` option to the CLI and passes the appropriate token via stdin if cli config parsing is enabled.
c17dc61
to
4023575
Compare
Failing test is because the cached version of the cli is too old to be using cli config parsing now, so the cli config files are not generated. The test will start passing when the cached version becomes 2.11.6. |
@henrymercer, I think you are the one with the most background to review. Can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments, but this looks generally good to me 👍
Failures due to using a kotlin version that is too new. Updating the base branch should fix it. |
This commit does a few related things:
are not downloaded by the action. It happens in the CLI.
--external-repository-token-stdin
option to the CLIand passes the appropriate token via stdin if cli config parsing is
enabled.
See the linked, internal PR for the integration test associated with this change.
Merge / deployment checklist