Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report configuration errors more accurately #2012

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Report configuration errors more accurately #2012

merged 1 commit into from
Dec 1, 2023

Conversation

henrymercer
Copy link
Contributor

This PR improves our telemetry by categorizing more configuration errors accordingly.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner December 1, 2023 17:56
aeisenberg
aeisenberg approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these changes make sense to me.

@henrymercer henrymercer merged commit b929cca into main Dec 1, 2023
337 checks passed
@henrymercer henrymercer deleted the henrymercer/categorize-configuration-errors branch December 1, 2023 18:34
This was referenced Dec 4, 2023
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrymercer @aeisenberg