Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat status reports as non-critical #2121

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Treat status reports as non-critical #2121

merged 1 commit into from
Feb 12, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Feb 8, 2024 •
edited by angelapwen
Loading

Resolve github/codeql#15462 (comment) by converting sendStatusReport into a function that always returns void and uses core.warning instead of core.error

Split from:

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@jsoref jsoref requested a review from a team as a code owner February 8, 2024 03:09
@jsoref jsoref mentioned this pull request Feb 8, 2024
Merged
angelapwen
angelapwen reviewed Feb 8, 2024
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this — our telemetry reporting should indeed be non-critical! I've just added a few comments.

I think this may warrant a CHANGELOG entry 🌞 users who may have seen this failure in the past should be happy to see the change.

src/upload-lib.ts Outdated Show resolved Hide resolved
src/upload-lib.ts Outdated Show resolved Hide resolved
@ffried ffried mentioned this pull request Feb 8, 2024
Open
@jsoref jsoref force-pushed the status-reports-are-not-critical branch 2 times, most recently from 6145d06 to d3f9862 Compare February 8, 2024 19:05
@jsoref jsoref requested a review from angelapwen February 8, 2024 19:07
This was referenced Feb 8, 2024
Open
Open
aeisenberg
aeisenberg reviewed Feb 9, 2024
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. I have a few copy-editing suggestions and one question about 404/403 errors.

package.json Outdated Show resolved Hide resolved
src/status-report.ts Outdated Show resolved Hide resolved
src/status-report.ts Outdated Show resolved Hide resolved
src/upload-lib.ts Outdated Show resolved Hide resolved
src/upload-lib.ts Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@jsoref jsoref force-pushed the status-reports-are-not-critical branch from ac030dd to 5942183 Compare February 9, 2024 21:02
aeisenberg
aeisenberg previously approved these changes Feb 9, 2024
View reviewed changes
src/upload-lib.ts
@@ -16,6 +16,11 @@ import { parseRepositoryNwo, RepositoryNwo } from "./repository";
import * as util from "./util";
import { SarifFile, ConfigurationError, wrapError } from "./util";

const GENERIC_403_MSG =
"The repo on which this action is running has not opted-in to CodeQL code scanning.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message and the one below it needs some work, but as you mentioned, it is outside the scope of this PR.

@aeisenberg
Copy link
Contributor

Thanks again for your work on this.

jsoref
jsoref commented Feb 12, 2024
View reviewed changes
src/status-report.ts Outdated Show resolved Hide resolved
aeisenberg
aeisenberg previously approved these changes Feb 12, 2024
View reviewed changes
@aeisenberg aeisenberg enabled auto-merge February 12, 2024 18:41
@aeisenberg aeisenberg disabled auto-merge February 12, 2024 18:41
@jsoref
Treat status reports as non-critical
5a6da1d 
Change `sendStatusReport` to `void`
@jsoref jsoref force-pushed the status-reports-are-not-critical branch from df25046 to 5a6da1d Compare February 12, 2024 18:56
@jsoref jsoref requested a review from aeisenberg February 12, 2024 18:56
@aeisenberg aeisenberg merged commit 4075abf into github:main Feb 12, 2024
295 checks passed
@aeisenberg
Copy link
Contributor

Thanks again! Nice work here.

@jsoref jsoref deleted the status-reports-are-not-critical branch February 12, 2024 21:07
@github-actions github-actions bot mentioned this pull request Feb 13, 2024
Merged
8 tasks
@henrymercer henrymercer mentioned this pull request Feb 13, 2024
Merged
13 tasks
This was referenced May 13, 2024
Open
Open
This was referenced May 14, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

@angelapwen angelapwen Awaiting requested review from angelapwen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workflows are missing permissions requests
3 participants
@jsoref @aeisenberg @angelapwen