Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve logging coverage during sarif upload #2221

Merged
merged 7 commits into from
Apr 4, 2024

Conversation

nickfyson
Copy link
Contributor

@nickfyson nickfyson commented Apr 3, 2024

This PR improves the coverage of logging when uploading SARIF files, in order to help catch where stalled action runs have encountered problems.

I've mostly added the log lines as info since this didn't seem excessively noisy, except for a few where the level is debug.

Does this seem a reasonable balance...? 🤷‍♂️

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@nickfyson nickfyson changed the title Nickfyson/upload logging improve logging coverage during sarif upload Apr 3, 2024
@nickfyson nickfyson marked this pull request as ready for review April 3, 2024 14:45
@nickfyson nickfyson requested a review from a team as a code owner April 3, 2024 14:45
@nickfyson nickfyson marked this pull request as draft April 3, 2024 14:47
@nickfyson nickfyson marked this pull request as ready for review April 3, 2024 15:40
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A couple of suggestions:

src/fingerprints.ts Outdated Show resolved Hide resolved
src/upload-lib.ts Outdated Show resolved Hide resolved
src/upload-lib.ts Outdated Show resolved Hide resolved
src/upload-lib.ts Outdated Show resolved Hide resolved
src/upload-lib.ts Outdated Show resolved Hide resolved
Co-authored-by: Henry Mercer <henrymercer@github.com>
@nickfyson nickfyson merged commit 5f535de into main Apr 4, 2024
297 checks passed
@nickfyson nickfyson deleted the nickfyson/upload-logging branch April 4, 2024 16:30
@koesie10 koesie10 mentioned this pull request Apr 17, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants