-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run integration test PR checks nightly #2222
Conversation
Oops. Still in draft. Code looks good. Let's if everything passes. |
I still haven't configured a notification to our team if any of these fail (see backlinked issue). I can do that in a follow-up if we want to start running immediately though. |
Huh... workflow files don't seem to be working with an error message:
I'll look into it but nothing comes top of mind as EDIT: I think I see the syntax error, will fix |
f4013bf
to
1932e6e
Compare
Scheduled for 5AM UTC. This will assist in catching bugs introduced with new runner images.
1932e6e
to
9a9987f
Compare
For consistency with our non-autogenerated files and GitHub documentation, we should further indent items in lists (`sequence`).
PR check failures are now due to upstream (usually transient) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable. If the failures are transient, I'll leave it up to you if you want to override the failures and merge or re-run later.
I don't think we have a way to force green on this repo, and I'd rather not make all those checks non-required (and then make them required again later), so I'll wait to re-run. |
Scheduled for 5AM UTC. This will assist in catching bugs introduced with new runner images.
Merge / deployment checklist