Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow feature flags to specify tool feature requirements #2236

Merged

Conversation

henrymercer
Copy link
Contributor

Tool features are great because we can start testing new features that rely on CLI functionality in nightly builds. So let's allow our feature flags to depend on them rather than specifying a minimum version of CodeQL.

I've included a motivating example since this fits more nicely into the test framework we have for feature flags. I'll put a PR up using that example shortly.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner April 12, 2024 15:16
@henrymercer henrymercer merged commit 5a599c6 into main Apr 12, 2024
315 checks passed
@henrymercer henrymercer deleted the henrymercer/feature-flags-with-tool-feature-dependencies branch April 12, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants