Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatibility between direct tracing in the autobuild Action and specifying a custom working directory #2328

Merged
merged 8 commits into from
Jun 13, 2024

Conversation

henrymercer
Copy link
Contributor

This PR fixes an issue with the AutobuildDirectTracing feature where it would ignore the working-directory input to the autobuild Action. The fix is to pass Node's working directory to the CLI, since we already change directory in Node based on the input. We also bump the version of the feature flag so that we can avoid re-enabling the flag for old Action versions.

I've added a PR check to validate that the fix works.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner June 11, 2024 17:18
aeisenberg
aeisenberg previously approved these changes Jun 11, 2024
src/database-upload.ts Show resolved Hide resolved
We are already testing the analyze Action in a separate check.
Just call `analyze`, since `upload: never` skips most of the functionality we want to test anyway.
@henrymercer henrymercer merged commit 789b5f8 into main Jun 13, 2024
300 checks passed
@henrymercer henrymercer deleted the henrymercer/direct-tracing-fix branch June 13, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants