Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump artifacts dependencies #2461

Closed
wants to merge 6 commits into from
Closed

Bump artifacts dependencies #2461

wants to merge 6 commits into from

Commits on Sep 4, 2024

  1. Import @actions/artifact@v1 as artifact-legacy and v2 as artifact

    @angelapwen
    angelapwen committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    cdcb85f View commit details
    Browse the repository at this point in the history

  2. Upload with artifacts-legacy when running GHES, else with artifacts 

    `@actions/artifacts@v1` is still not yet supported on GHES and we need to maintain backwards compatibility here. If we detect that a user is running on GHES, we fall back on the original `v1` import.
    @angelapwen
    angelapwen committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    d5ac485 View commit details
    Browse the repository at this point in the history

  3. PR Checks: use v4 of upload-artifact and download-artifact 

    We can do this now that we have upgraded to `@actions/artifact@v2`; note that on GHES we are still using `@actions/artifact@v1`, but our PR checks are not running on GHES.
    @angelapwen
    angelapwen committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    df0bf04 View commit details
    Browse the repository at this point in the history

  4. Normalize paths in new artifact upload to match legacy upload

    @angelapwen
    angelapwen committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    2992a95 View commit details
    Browse the repository at this point in the history

  5. Test with unique artifact name for v4 update

    @angelapwen
    angelapwen committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    3c37ab4 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Draft: upload artifacts only in post-init, and combined SARIF artif… 

    …acts at most once
    @angelapwen
    angelapwen committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    f249716 View commit details
    Browse the repository at this point in the history