Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging when preparing and uploading debug artifacts #2488

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Improve logging when preparing and uploading debug artifacts #2488

merged 3 commits into from
Sep 17, 2024

Conversation

henrymercer
Copy link
Contributor

Improve the logging during these steps so it's easier to tell what's going on and easier to debug in the case of a failure.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner September 17, 2024 09:16
NlightNFotis
NlightNFotis approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of questions.

src/debug-artifacts.ts Outdated Show resolved Hide resolved
src/debug-artifacts.ts Show resolved Hide resolved
@henrymercer henrymercer merged commit 34666c1 into main Sep 17, 2024
312 checks passed
@henrymercer henrymercer deleted the henrymercer/debug-artifacts-better-logging branch September 17, 2024 20:07
@github-actions github-actions bot mentioned this pull request Sep 19, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NlightNFotis NlightNFotis NlightNFotis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrymercer @NlightNFotis