-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update integration test pack versions #721
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if tests pass.
Should these always use the latest version? Or is the point that we're testing both explicit versions and implicit latest versions?
Darn...tests still failing. I think I need to create a version 0.0.4 of javascript-all. There must be some dbscheme change that hasn't yet been picked up. |
It's still failing. I'm not sure exactly why. I updated both test packs to use the latest |
|
I guess it's also possible that the dbscheme of the compiled queries are too new and the upgrade script is not available, so the queries are failing. I'll have to look at this next week. |
aab4833
to
a9da277
Compare
I forced the failing tests to use the nightly build. Now they are passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a very temporary fix to unbreak the tests this seems okay, but we definitely need a more permanent solution that doesn't require us to keep manually bumping versions.
In retrospect, this is misleading. I wasn't implying that this is a good solution, or even something I'd like to commit. I'm planning on working on this tomorrow and finding out what is happening, because upgrades should work. @edoardopirovano as you said, this would only be temporary. If you are being blocked by failing builds, then it is ok to merge. But, I would prefer to explore deeper when I am able to. |
Agree that we should investigate why the upgrades aren't working. I'm not blocked on failing tests, so okay to not merge this and instead wait until we have a proper solution. |
fb4dd05
to
a033359
Compare
The 0.1.0 versions fail because the queries are too new and upgrades are not found. The bug is that we haven't updated I'll work on this next. |
These tests will not be properly fixed until the next release of the CLI. This is because database upgrades is not yet package-aware. I'll fix that shortly, but it won't be available until the release. |
Building a new nightly version of the CLI. I expect that once that version is available to the action, then this PR will pass and we can get the action back on track. |
a033359
to
8782c97
Compare
8782c97
to
d1ff4d6
Compare
This latest version hard-codes the tools bundle being used by the packaging integration tests. This will work for now. However, we need to make sure that the version that is pointed to is not cleaned up by automation. |
I made sure that the release is not cleaned up by automation by making it a non-prerelease. Now, it will always show on top of the releases list, which always keeps the 10 latest. |
Merge / deployment checklist