Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependabot issues #786

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Fix dependabot issues #786

merged 2 commits into from
Nov 3, 2021

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Oct 21, 2021

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@aeisenberg aeisenberg requested a review from a team as a code owner October 21, 2021 22:25
"bin": {
"semver": "bin/semver.js"
}
},
"node_modules/@actions/tool-cache/node_modules/uuid": {
"version": "3.4.0",
"license": "MIT",
"integrity": "sha512-HjSDRw6gZE5JMggctHBcjVak08+KEVhSIiDzFnT9S9aegmp85S/bReBVTb4QTFaRNptJ9kuYaNhnbNEOkbKb/A==",
"deprecated": "Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we upgrade past this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a transitive dependency of actions/tool-cache, so not sure. But I will try.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency is coming from https://github.com/actions/toolkit/blob/main/packages/tool-cache/package.json#L44. I raised an issue to request upgrading the dependency. actions/toolkit#925. There's not much I can do in this repo to fix it. It will need to be fixed in the dependency, which I will create a PR for.

@aeisenberg aeisenberg force-pushed the aeisenberg/dependabot branch from 85271fa to 531c6ba Compare October 25, 2021 15:56
@aeisenberg aeisenberg merged commit ff3272d into main Nov 3, 2021
@aeisenberg aeisenberg deleted the aeisenberg/dependabot branch November 3, 2021 16:56
@github-actions github-actions bot mentioned this pull request Nov 4, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants