Skip to content

Commit

Permalink
Dataflow: One more minor perf tweak.
Browse files Browse the repository at this point in the history
  • Loading branch information
aschackmull committed Sep 13, 2023
1 parent b63d518 commit 74787bf
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
Original file line number Diff line number Diff line change
Expand Up @@ -1517,7 +1517,7 @@ module MakeImpl<InputSig Lang> {

pragma[nomagic]
private predicate fwdFlowOutCand(
DataFlowCall call, DataFlowCallable inner, NodeEx out, FlowState state, CcNoCall outercc,
DataFlowCall call, DataFlowCallable inner, NodeEx out, FlowState state,
ParamNodeOption summaryCtx, TypOption argT, ApOption argAp, Typ t, Ap ap, ApApprox apa
) {
exists(RetNodeEx ret, boolean allowsFieldFlow, CcNoCall innercc |
Expand All @@ -1531,7 +1531,6 @@ module MakeImpl<InputSig Lang> {
innercc)
)
|
outercc = getCallContextReturn(inner, call) and
if allowsFieldFlow = false then ap instanceof ApNil else any()
)
}
Expand All @@ -1540,8 +1539,9 @@ module MakeImpl<InputSig Lang> {
DataFlowCall call, DataFlowCallable inner, NodeEx out, FlowState state, CcNoCall outercc,
ParamNodeOption summaryCtx, TypOption argT, ApOption argAp, Typ t, Ap ap, ApApprox apa
) {
fwdFlowOutCand(call, inner, out, state, outercc, summaryCtx, argT, argAp, t, ap, apa) and
FwdTypeFlow::typeFlowValidEdgeOut(call, inner)
fwdFlowOutCand(call, inner, out, state, summaryCtx, argT, argAp, t, ap, apa) and
FwdTypeFlow::typeFlowValidEdgeOut(call, inner) and
outercc = getCallContextReturn(inner, call)
}

private module FwdTypeFlowInput implements TypeFlowInput {
Expand Down

0 comments on commit 74787bf

Please sign in to comment.