Refactor HardcodedCredentials to use new SensitiveApi api

github · Aug 16, 2023 · ae03508 · ae03508
1 parent 2d1f0df
commit ae03508
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/java/ql/lib/semmle/code/java/security/HardcodedCredentials.qll b/java/ql/lib/semmle/code/java/security/HardcodedCredentials.qll
@@ -59,15 +59,10 @@ abstract class CredentialsSink extends Expr {
  */
 class CredentialsApiSink extends CredentialsSink {
   CredentialsApiSink() {
-    exists(Call call, int i |
-      this = call.getArgument(i) and
-      (
-        javaApiCallableUsernameParam(call.getCallee(), i) or
-        javaApiCallablePasswordParam(call.getCallee(), i) or
-        javaApiCallableCryptoKeyParam(call.getCallee(), i) or
-        otherApiCallableCredentialParam(call.getCallee(), i)
-      )
-    )
+    this = any(PasswordParameter p).asExpr() or
+    this = any(UsernameParameter p).asExpr() or
+    this = any(CryptoKeyParameter p).asExpr() or
+    this = any(CredentialParameter p).asExpr()
   }
 }