Data flow: Add ArgumentNode consistency checks
#14108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
dataflow/more-consistency-checks
branch
from
09ab248 to
a785db5
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hvitved
force-pushed
the
dataflow/more-consistency-checks
branch
2 times, most recently
from
96eb036 to
91b88a6
Compare
RasmusWL
force-pushed
the
dataflow/more-consistency-checks
branch
from
b597bf1 to
2658521
Compare
hvitved
force-pushed
the
dataflow/more-consistency-checks
branch
from
2658521 to
16ea0b3
Compare
hvitved
changed the title
hvitved
force-pushed
the
dataflow/more-consistency-checks
branch
2 times, most recently
from
01b86e4 to
26267a5
Compare
hvitved
force-pushed
the
dataflow/more-consistency-checks
branch
from
26267a5 to
ba068d2
Compare
hvitved
force-pushed
the
dataflow/more-consistency-checks
branch
from
ba068d2 to
2fa8117
Compare
hvitved
force-pushed
the
dataflow/more-consistency-checks
branch
from
2fa8117 to
40e2f64
Compare
hvitved
changed the title
hvitved
force-pushed
the
dataflow/more-consistency-checks
branch
from
40e2f64 to
d3558f8
Compare
hvitved
changed the title
ArgumentNode consistency checks
aschackmull
reviewed
Sep 13, 2023
aschackmull
reviewed
Sep 13, 2023
python/ql/lib/semmle/python/dataflow/new/internal/DataFlowImplConsistency.qll
Show resolved
Hide resolved
aschackmull
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two consistency checks for checking uniqueness and existence of
DataFlowCalls associated toArgumentNodes. While the data flow library can handleArgumentNodes belonging to multipleDataFlowCalls, it is good to check that this was indeed the intention. For C#, this would have highlighted #14099, and it also revealed four other kinds of inconsistencies (two of which have been fixed).