Swift: Fix for OptionSet and BinaryInteger models #18154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redsun82
approved these changes
Nov 29, 2024
|
Ah yes - I think the autoformatter was broken on my machine when I made this PR, so I gave up and crossed my fingers. Now fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix for the
OptionSetandBinaryIntegermodels for Swift 6. I'm particularly displeased with this one as there doesn't seem to be much reason whyBinaryIntegerwould apparently not derive fromCustomStringConvertibleany more (hence needing its own model of.description), though it does remind me of some of the changes in #17989 to integral type models. Similarly forOptionSet, either it's been divorced fromRawRepresentableor for some reason we're not extracting the association correctly any more.In any case, all of the test regressions I'm aware of are now fixed.