Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust: extract crate graph #18228

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Rust: extract crate graph #18228

wants to merge 20 commits into from

Conversation

aibaars
Copy link
Contributor

@aibaars aibaars commented Dec 6, 2024

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Dec 6, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 6, 2024
View reviewed changes
rust/ql/lib/codeql/rust/elements.qll Fixed Show fixed Hide fixed
rust/ql/lib/codeql/rust/elements.qll
@@ -96,6 +100,7 @@
import codeql.rust.elements.MethodCallExpr
import codeql.rust.elements.Missing
import codeql.rust.elements.Module
import codeql.rust.elements.ModuleContainer

Check warning

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.Crate
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.CrateModule
Loading
.
rust/ql/lib/codeql/rust/elements.qll
import codeql.rust.elements.TypeArg
import codeql.rust.elements.TypeBound
import codeql.rust.elements.TypeBoundList
import codeql.rust.elements.TypeItem

Check warning

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.CrateModule
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.EnumItem
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.StructItem
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TraitItem
Loading
.
rust/ql/lib/codeql/rust/elements.qll
@@ -168,7 +175,9 @@
import codeql.rust.elements.Use
import codeql.rust.elements.UseTree
import codeql.rust.elements.UseTreeList
import codeql.rust.elements.ValueItem

Check warning

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.CrateModule
Loading
.
rust/ql/lib/codeql/rust/elements.qll
import codeql.rust.elements.Variant
import codeql.rust.elements.VariantData

Check warning

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.EnumVariant
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.StructItem
Loading
.
rust/ql/lib/codeql/rust/elements/EnumVariant.qll
*/

private import internal.EnumVariantImpl
import codeql.rust.elements.Element

Check warning

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.VariantData
Loading
.
@aibaars aibaars force-pushed the aibaars/crate-graph branch 5 times, most recently from 48783f3 to e0ecf47 Compare December 9, 2024 16:56
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 9, 2024
View reviewed changes
rust/extractor/src/generated/top.rs Fixed Show fixed Hide fixed
rust/extractor/src/generated/top.rs Fixed Show fixed Hide fixed
rust/extractor/src/generated/top.rs Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 9, 2024
View reviewed changes
rust/ql/lib/codeql/rust/elements.qll
import codeql.rust.elements.DynTraitTypeRepr
import codeql.rust.elements.Element
import codeql.rust.elements.Enum
import codeql.rust.elements.EnumItem
import codeql.rust.elements.EnumVariant

Check warning

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.EnumItem
Loading
.
rust/ql/lib/codeql/rust/elements.qll
import codeql.rust.elements.TupleTypeRepr
import codeql.rust.elements.Type

Check warning

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.ArrayType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.DynTraitType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ErrorType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.FunctionType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ImplItem
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ImplTraitType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.NeverType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.PathType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.PlaceholderType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.RawPtrType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ReferenceType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.SliceType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TupleType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ValueItem
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.VariantData
Loading
.
rust/ql/lib/codeql/rust/elements/ValueItem.qll
*/

private import internal.ValueItemImpl
import codeql.rust.elements.Element

Check warning

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.Type
Loading
.
rust/ql/lib/codeql/rust/elements/VariantData.qll
*/

private import internal.VariantDataImpl
import codeql.rust.elements.Element

Check warning

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.Type
Loading
.
@aibaars aibaars force-pushed the aibaars/crate-graph branch 5 times, most recently from 9f083b9 to 7419e77 Compare December 11, 2024 09:10
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 16, 2024
View reviewed changes
rust/ql/lib/codeql/rust/elements.qll
import codeql.rust.elements.ForTypeRepr
import codeql.rust.elements.Format
import codeql.rust.elements.FormatArgsArg
import codeql.rust.elements.FormatArgsExpr
import codeql.rust.elements.FormatArgument
import codeql.rust.elements.FormatTemplateVariableAccess
import codeql.rust.elements.Function
import codeql.rust.elements.FunctionType

Check warning

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.ImplItem
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TraitItem
Loading
.
rust/ql/lib/codeql/rust/elements.qll
import codeql.rust.elements.GenericArg
import codeql.rust.elements.GenericArgList
import codeql.rust.elements.GenericParam
import codeql.rust.elements.GenericParamList
import codeql.rust.elements.IdentPat
import codeql.rust.elements.IfExpr
import codeql.rust.elements.Impl
import codeql.rust.elements.ImplItem

Check warning

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.CrateModule
Loading
.
rust/ql/lib/codeql/rust/elements.qll
import codeql.rust.elements.TypeAlias
import codeql.rust.elements.TypeArg
import codeql.rust.elements.TypeBound
import codeql.rust.elements.TypeBoundList
import codeql.rust.elements.TypeBoundType

Check warning

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.DynTraitType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ForLifetimeTypeBound
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.ImplTraitType
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.LifetimeTypeBound
Loading
.
Redundant import, the module is already imported inside
codeql.rust.elements.TraitTypeBound
Loading
.
rust/ql/lib/codeql/rust/elements/ImplItem.qll
*/

private import internal.ImplItemImpl
import codeql.rust.elements.Element

Check warning

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.Type
Loading
.
rust/ql/lib/codeql/rust/elements/ImplItem.qll
private import internal.ImplItemImpl
import codeql.rust.elements.Element
import codeql.rust.elements.FunctionType
import codeql.rust.elements.Type

Check warning

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.FunctionType
Loading
.
rust/ql/lib/codeql/rust/elements/internal/generated/ImplItem.qll
private import codeql.rust.elements.internal.generated.Raw
import codeql.rust.elements.internal.ElementImpl::Impl as ElementImpl
import codeql.rust.elements.FunctionType
import codeql.rust.elements.Type

Check warning

Code scanning / CodeQL

Redundant import Warning generated

Redundant import, the module is already imported inside
codeql.rust.elements.FunctionType
Loading
.
@aibaars aibaars force-pushed the aibaars/crate-graph branch 2 times, most recently from ef5ef98 to 4c9e103 Compare December 18, 2024 13:25
@aibaars aibaars force-pushed the aibaars/crate-graph branch from 4c9e103 to 83111f3 Compare December 18, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aibaars