Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Support non-type template parameters #18320

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Dec 18, 2024

Pull Request checklist

All query authors

Internal query authors only

  • Autofixes generated based on these changes are valid, only needed if this PR makes significant changes to .ql, .qll, or .qhelp files. See the documentation (internal access required).
  • Changes are validated at scale (internal access required).
  • Adding a new query? Consider also adding the query to autofix.

@jketema jketema force-pushed the template-parameters branch from 1306e48 to 87f12ac Compare December 18, 2024 16:37
@jketema jketema added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Dec 19, 2024
@jketema jketema marked this pull request as ready for review December 19, 2024 07:28
@Copilot Copilot bot review requested due to automatic review settings December 19, 2024 07:28
@jketema jketema requested a review from a team as a code owner December 19, 2024 07:28

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 12 changed files in this pull request and generated no comments.

Files not reviewed (6)
  • cpp/downgrades/d6a03a00b9824f27241b58b8e18208f31c03904a/upgrade.properties: Language not supported
  • cpp/ql/lib/cpp.qll: Language not supported
  • cpp/ql/lib/semmle/code/cpp/TemplateParameter.qll: Language not supported
  • cpp/ql/lib/semmle/code/cpp/Type.qll: Language not supported
  • cpp/ql/lib/semmlecode.cpp.dbscheme: Language not supported
  • cpp/ql/lib/upgrades/f0156f5f88ab5967c79162012c20f30600ca5ebf/upgrade.properties: Language not supported

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@jketema jketema merged commit 84b60d2 into github:main Dec 19, 2024
18 checks passed
@jketema jketema deleted the template-parameters branch December 19, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants