-
Notifications
You must be signed in to change notification settings - Fork 59.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #18260 from github/repo-sync
repo sync
- Loading branch information
Showing
4 changed files
with
74 additions
and
70 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
import { describe, jest } from '@jest/globals' | ||
|
||
import { getDOM, getJSON } from '../helpers/e2etest.js' | ||
import nonEnterpriseDefaultVersion from '../../lib/non-enterprise-default-version.js' | ||
|
||
describe('mobile-only products nav', () => { | ||
const cases = [ | ||
// Note the unversioned homepage at `/` does not have a product selected in the mobile dropdown | ||
['/github', 'GitHub'], | ||
// Enterprise server | ||
['/en/enterprise/admin', 'Enterprise administrators'], | ||
[ | ||
'/en/enterprise/get-started/importing-your-projects-to-github/importing-source-code-to-github/importing-a-git-repository-using-the-command-line', | ||
'Get started', | ||
], | ||
|
||
['/desktop', 'GitHub Desktop'], | ||
['/actions', 'GitHub Actions'], | ||
|
||
// localized | ||
['/ja/desktop', 'GitHub Desktop'], | ||
] | ||
|
||
test.each(cases)('on %p, renders current product %p', async (url, name) => { | ||
expect((await getDOM(url))('[data-testid=product-picker] summary').text().trim()).toBe(name) | ||
}) | ||
}) | ||
|
||
describe('products middleware', () => { | ||
jest.setTimeout(5 * 60 * 1000) | ||
|
||
test('adds res.context.activeProducts array', async () => { | ||
const products = await getJSON('/en?json=activeProducts') | ||
expect(Array.isArray(products)).toBe(true) | ||
}) | ||
|
||
test('adds res.context.currentProduct string on homepage', async () => { | ||
const currentProduct = await getJSON('/en?json=currentProduct') | ||
expect(currentProduct).toBe('homepage') | ||
}) | ||
|
||
test('adds res.context.currentProduct object', async () => { | ||
const currentProduct = await getJSON( | ||
`/en/${nonEnterpriseDefaultVersion}/github?json=currentProduct` | ||
) | ||
expect(currentProduct).toBe('github') | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
import { describe, jest } from '@jest/globals' | ||
|
||
import { allVersions } from '../../lib/all-versions.js' | ||
import { latest } from '../../lib/enterprise-server-releases.js' | ||
import nonEnterpriseDefaultVersion from '../../lib/non-enterprise-default-version.js' | ||
import { getJSON } from '../helpers/e2etest.js' | ||
|
||
describe('versions middleware', () => { | ||
jest.setTimeout(60 * 1000) | ||
|
||
test('adds res.context.allVersions object', async () => { | ||
const allVersionsFromMiddleware = await getJSON('/en?json=allVersions') | ||
expect(allVersionsFromMiddleware).toEqual(allVersions) | ||
}) | ||
|
||
test('adds res.context.currentVersion string', async () => { | ||
let currentVersion = await getJSON('/en?json=currentVersion') | ||
expect(currentVersion).toBe(nonEnterpriseDefaultVersion) | ||
|
||
currentVersion = await getJSON(`/en/${nonEnterpriseDefaultVersion}?json=currentVersion`) | ||
expect(currentVersion).toBe(nonEnterpriseDefaultVersion) | ||
|
||
currentVersion = await getJSON(`/en/enterprise-server@${latest}?json=currentVersion`) | ||
expect(currentVersion).toBe(`enterprise-server@${latest}`) | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters