-
Notifications
You must be signed in to change notification settings - Fork 60.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests may be broken on Windows #137
Comments
Hi 👋🏼 When you run |
|
Thanks for the information :) I would try updating to Node version 12.18.3 first. Many of these errors look like features that came in later Node versions. |
Oh wow - it sounds as if I'm a long way out of date 😞 |
Ah - somehow I typed the wrong thing - I should have waited until the morning to answer. I'm not so far out of date when I try the right command: |
Having upgraded, it looks as if it's better but I still see errors and the tests appear to get stuck after The following output is for the same
```
$ npm test
PASS tests/content/remove-liquid-statements.js
● client-side JavaScript bundle › returns a 200 response
● client-side JavaScript bundle › sets the right content-type header
PASS tests/rendering/header.js (34.49 s)
● article links › in "content\enterprise\admin\enterprise-management\migrating-from-github-enterprise-1110x-to-2123.md" › URLs must not contain a hard-coded version number
● article links › in "content\enterprise\admin\user-management\configuring-email-for-notifications.md" › relative URLs must start with "/"
● article links › in "content\github\building-a-strong-community\editing-wiki-content.md" › relative URLs must start with "/"
● article links › in "content\github\building-a-strong-community\manually-creating-a-single-issue-template-for-your-repository.md" › relative URLs must start with "/"
● article links › in "content\github\enforcing-best-practices-with-github-policies\constraints.md" › relative URLs must start with "/"
● article links › in "content\github\enforcing-best-practices-with-github-policies\overview.md" › relative URLs must start with "/"
● article links › in "content\github\finding-security-vulnerabilities-and-errors-in-your-code\sarif-support-for-code-scanning.md" › relative URLs must start with "/"
● article links › in "content\rest\overview\libraries.md" › relative URLs must start with "/"
● article links › in "data\reusables\repositories\relative-links.md" › relative URLs must start with "/"
PASS tests/content/site-data-references.js (17.319 s)
PASS tests/unit/liquid.js
PASS tests/content/remove-liquid-statements.js
● stylesheets › compiles and sets the right content-type header
● client-side JavaScript bundle › returns a 200 response
● client-side JavaScript bundle › sets the right content-type header
PASS tests/rendering/header.js (34.021 s)
PASS tests/routing/middleware/redirects/help-to-docs.js
● article links › in "content\enterprise\admin\enterprise-management\migrating-from-github-enterprise-1110x-to-2123.md" › URLs must not contain a hard-coded version number
● article links › in "content\enterprise\admin\user-management\configuring-email-for-notifications.md" › relative URLs must start with "/"
● article links › in "content\github\building-a-strong-community\editing-wiki-content.md" › relative URLs must start with "/"
● article links › in "content\github\building-a-strong-community\manually-creating-a-single-issue-template-for-your-repository.md" › relative URLs must start with "/"
● article links › in "content\github\enforcing-best-practices-with-github-policies\constraints.md" › relative URLs must start with "/"
● article links › in "content\github\enforcing-best-practices-with-github-policies\overview.md" › relative URLs must start with "/"
● article links › in "content\github\finding-security-vulnerabilities-and-errors-in-your-code\sarif-support-for-code-scanning.md" › relative URLs must start with "/"
● article links › in "content\rest\overview\libraries.md" › relative URLs must start with "/"
● article links › in "data\reusables\repositories\relative-links.md" › relative URLs must start with "/"
PASS tests/content/site-data-references.js (17.258 s)
PASS tests/unit/liquid.js
● page rendering › every page has links with anchors that can be resolved
● page rendering › every page has links that can be resolved
A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --runInBand --detectOpenHandles to find leaks.
● stylesheets › compiles and sets the right content-type header
● client-side JavaScript bundle › returns a 200 response
● client-side JavaScript bundle › sets the right content-type header
FAIL tests/content/article-links.js (106.856 s)
● article links › in "content\enterprise\admin\enterprise-management\migrating-from-github-enterprise-1110x-to-2123.md" › URLs must not contain a hard-coded version number
● article links › in "content\enterprise\admin\user-management\configuring-email-for-notifications.md" › relative URLs must start with "/"
● article links › in "content\github\building-a-strong-community\editing-wiki-content.md" › relative URLs must start with "/"
● article links › in "content\github\building-a-strong-community\manually-creating-a-single-issue-template-for-your-repository.md" › relative URLs must start with "/"
● article links › in "content\github\enforcing-best-practices-with-github-policies\constraints.md" › relative URLs must start with "/"
● article links › in "content\github\enforcing-best-practices-with-github-policies\overview.md" › relative URLs must start with "/"
● article links › in "content\github\finding-security-vulnerabilities-and-errors-in-your-code\sarif-support-for-code-scanning.md" › relative URLs must start with "/"
● article links › in "content\rest\overview\libraries.md" › relative URLs must start with "/"
● article links › in "data\reusables\repositories\relative-links.md" › relative URLs must start with "/"
FAIL tests/unit/products.js (35.836 s)
FAIL tests/links-and-images/developer-links-and-images.js (1025.675 s)
● page rendering › every page has links with anchors that can be resolved
● page rendering › every page has links that can be resolved
Test Suites: 4 failed, 44 passed, 48 total
|
I'm working on the assumption that, since we ensure tests are green before we merge PRs, I shouldn't be seeing so many test failures on the default branch. |
You can see my output here
But some of the tests do appear to be broken on Also I've investigated using Docker as a way to make sure you have an identical development experience to the experience Mac and Linux users have. ... it's ready to use but rough around the edges. More details coming soon. |
Connected with @jeffmcaffer. He's going to run point on this and I'm going to pair with him as needed to provide some additional engineering support! |
Thank you. Do let me know if I can help by testing anything. |
@felicitymay things should be fixed here soon 🤞🏿 Thanks to @jeffmcaffer |
When I run tests locally using
npm test
on master:I get the following output:
The text was updated successfully, but these errors were encountered: