Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of workflow_run #23257

Closed
1 task done
makeable opened this issue Jan 17, 2023 · 6 comments
Closed
1 task done

Improve documentation of workflow_run #23257

makeable opened this issue Jan 17, 2023 · 6 comments
Labels
content This issue or pull request belongs to the Docs Content team developers Content related to developers waiting for review Issue/PR is waiting for a writer's review webhooks Content related to webhooks

Comments

@makeable
Copy link

makeable commented Jan 17, 2023

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#workflow_run
workflow_run is not well documented. There is NO information on what is contained in the workflow_run object in the payload

What part(s) of the article would you like to see updated?

I would like to see documentation explaining what is contained in the object. At present it just says "required"

Additional information

This has been raised a number of times and just gets closed.

@makeable makeable added the content This issue or pull request belongs to the Docs Content team label Jan 17, 2023
@welcome
Copy link

welcome bot commented Jan 17, 2023

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 17, 2023
@makeable
Copy link
Author

From further investigation, it seems that the openAPI descriptors may be at fault. If you choose a different action type other than completed then the payload displays. These seem to be generated automatically by some github internal process, so I guess it needs to be resolved there.,

@cmwilson21 cmwilson21 added waiting for review Issue/PR is waiting for a writer's review webhooks Content related to webhooks developers Content related to developers and removed triage Do not begin working on this issue until triaged by the team labels Jan 17, 2023
@cmwilson21
Copy link
Contributor

@makeable Thanks so much for opening an issue! I'll triage this for the team to take a look 👀

@skedwards88
Copy link
Contributor

Thanks for opening this issue! This looks like a bug that we need to fix internally, so I'm going close this issue and open an internal issue for our engineering team.

@rebwill
Copy link

rebwill commented Jun 26, 2023

I am not sure what fix was made on this a few months back, but the workflow_run event payload documentation is still lacking any reference for the workflow_run object.

About two weeks ago, I briefly saw a dropdown here under the workflow_run object that contained this information -- similar to what appears under the properties of workflow_job.deployment. However that dropdown disappeared the next time I reloaded the page, and I have not seen it again. I tried in Firefox and Chrome in case it was a browser issue, but no luck.

I believe this issue should be reopened.

@cmwilson21
Copy link
Contributor

@rebwill Thanks for the added context! Would you mind opening a new issue with this information? Please link to this issue as well 👍

Then I get this triaged for review again 💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team developers Content related to developers waiting for review Issue/PR is waiting for a writer's review webhooks Content related to webhooks
Projects
None yet
Development

No branches or pull requests

4 participants