Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for workflow_run event payload properties #26319

Closed
1 task done
rebwill opened this issue Jun 28, 2023 · 7 comments
Closed
1 task done

Add documentation for workflow_run event payload properties #26319

rebwill opened this issue Jun 28, 2023 · 7 comments
Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Comments

@rebwill
Copy link

rebwill commented Jun 28, 2023

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/webhooks-and-events/webhooks/webhook-events-and-payloads#workflow_run

What part(s) of the article would you like to see updated?

The workflow_run event payload documentation is lacking any reference for the workflow_run object.

About two weeks ago, I briefly saw a dropdown here under the workflow_run object. The dropdown was similar to what appears under the dropdown properties of workflow_job.deployment. However the workflow_run dropdown disappeared the next time I reloaded the page, and I have not seen it again. I tried in Firefox and Chrome in case it was a browser issue, but no luck. In the attached screenshot you can see a blank space at the bottom, below the workflow_run body parameter.

I have not been able to find an official (or even unofficial!) documentation for what the workflow_run event payload contains. This has made what should have been a simple use case (a Slack integration for notifications for failed workflow runs) rather frustrating. I've seen a few issues related to this topic. In #23257 I was encouraged to open a new issue for this specifically.

Expected outcome:
Detailed documentation of the properties that the workflow_run event payload object contains.

Additional information

image
@rebwill rebwill added the content This issue or pull request belongs to the Docs Content team label Jun 28, 2023
@welcome
Copy link

welcome bot commented Jun 28, 2023

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 28, 2023
@cmwilson21
Copy link
Contributor

👋 @rebwill - Thanks for opening the issue! ✨

I'll get this triaged for review! ⚡

Thank you for your interest in improving GitHub Docs! 💖

@cmwilson21 cmwilson21 added waiting for review Issue/PR is waiting for a writer's review webhook-description and removed triage Do not begin working on this issue until triaged by the team labels Jun 30, 2023
@docs-bot
Copy link
Collaborator

Thank you for opening this issue! Updates to the REST API, GraphQL API, and webhook reference documentation must be made internally. I have copied your issue to an internal issue, so I will close this issue.

@cmwilson21
Copy link
Contributor

@rebwill Just a heads up, any changes with the /webhook-events-and-payloads docs have to be made internally. The issue has been transferred and will be reviewed soon ✨

@skedwards88
Copy link
Contributor

Thanks for raising this issue! While we fix this bug, I just want to drop a note that you can find details about this property if you look at the docs for the requested action: https://docs.github.com/en/webhooks-and-events/webhooks/webhook-events-and-payloads?actionType=requested#workflow_run

@rebwill
Copy link
Author

rebwill commented Jun 30, 2023

Wow, thanks for the heads up @skedwards88, that would explain why I swore I had actually seen the properties before -- it must have actually been at that link you shared.

@rebwill
Copy link
Author

rebwill commented Jul 6, 2023

An additional piece of data I just noticed:

At the link shared above (https://docs.github.com/en/webhooks-and-events/webhooks/webhook-events-and-payloads?actionType=requested#workflow_run), the workflow_run object only has the dropdown with all of its properties (on Action Type: requested). It does not have the dropdown when Action Type: in_progress or Action Type: completed are selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

No branches or pull requests

4 participants