Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting is not applied correctly on 'Adding ssh-key steps ..' #27153

Closed
1 task done
Mallikarjunople opened this issue Jul 30, 2023 · 3 comments
Closed
1 task done

Formatting is not applied correctly on 'Adding ssh-key steps ..' #27153

Mallikarjunople opened this issue Jul 30, 2023 · 3 comments
Labels
content This issue or pull request belongs to the Docs Content team

Comments

@Mallikarjunople
Copy link

Code of Conduct

What article on docs.github.com is affected?

I am noticing the issue in this article. When I switched the tab to Windows I faced this issue in the formatting for steps in the Adding your SSH key to the ssh-agent section. I have attached the screenshot and video recording of the same. I also tried refreshing the browser but issue persists.
Screenshot:
github-docs-issue
Video:
https://github.com/github/docs/assets/45136568/7c270f0e-b7d0-4aa0-8a72-bfd7c680e72c

I am using a mac mini with macOS Venture 13.4 and my browser is Google chrome (Version 115.0.5790.114 (Official Build) (arm64)).

For macOS and linux, the formatting for the steps looks correct but for windows tab, the formatting is not correct.

What changes are you suggesting?

I suggest that the issue should be fixed as soon as possible. The formatting should be seen equivalent for all macOS, windows and linux platform tabs in the docs.

This is required as new readers might get bad UI experience when referring the docs.
Fixing this issue will help the readers of the docs to be able to refer the docs smoothly.

Additional information

No response
@Mallikarjunople Mallikarjunople added the content This issue or pull request belongs to the Docs Content team label Jul 30, 2023
@welcome
Copy link

welcome bot commented Jul 30, 2023

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 30, 2023
dane added a commit to dane/docs.github.com that referenced this issue Jul 31, 2023
@dane
Fix rendering of SSH key instructions for Windows and Linux
6b07476 
The reported issue github#27153 is for a Windows rendering problem,
but once I fixed that, the Linux instructions rendered incorrectly too.

Fixes github#27153
@dane dane mentioned this issue Jul 31, 2023
Closed
2 tasks
@dane
Copy link

dane commented Jul 31, 2023

@Mallikarjunople this should be fixed as of today in #27174.

@cmwilson21
Copy link
Contributor

@Mallikarjunople Thanks for opening an issue! As @dane stated, this was fixed internally. If you are still having issues with it, let me know and I'll reopen, but going ahead and closing it now 💛

Thank you for your interest in improving GitHub Docs! 💖

@cmwilson21 cmwilson21 removed the triage Do not begin working on this issue until triaged by the team label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix rendering of SSH key instructions for Windows and Linux dane/docs.github.com
3 participants
@Mallikarjunople @dane @cmwilson21