Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show new node.js version #113

Closed
wants to merge 1 commit into from
Closed

Show new node.js version #113

wants to merge 1 commit into from

Conversation

simpsoka
Copy link
Contributor

@simpsoka simpsoka commented Oct 6, 2020

new node.js version

Update development.md
a6aa75d 
new node.js version
@simpsoka simpsoka requested a review from zeke October 6, 2020 00:21
zeke
zeke approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@zeke zeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually just added this file to the checklist in https://github.com/github/docs-internal/blob/main/contributing/node-versions.md but somehow skipped over it.

Thank you! 👍🏼

@simpsoka
Copy link
Contributor Author

simpsoka commented Oct 6, 2020

I was in there already cause I was making updates to the contributing guides. :)

@zeke
Copy link
Contributor

zeke commented Oct 6, 2020

I'm not sure why that issue triage workflow is failing but we can safely ignore it here. I opened an issue for that here: https://github.com/github/docs-internal/issues/15903

@zeke
Copy link
Contributor

zeke commented Oct 6, 2020

Conflicts! Turn out this was already correct on main (I coulda sworn I updated it!), but this branch was behind main and didn't have that change yet. Closing!

@zeke zeke closed this Oct 6, 2020
@chiedo chiedo deleted the simpsoka-patch-1 branch November 30, 2020 15:30
jnidzwetzki referenced this pull request in jnidzwetzki/docs Oct 6, 2022
@Loquacity
Fixes to Actions documentation (#115)
4ade290 
* Fixes to Actions documentation based on GitHub issues #110, #111, #112, #113, #114

* additional link fixes

* One more

Co-authored-by: Lana Brindley <github@lanabrindley.com>
@mongoloidkhulmikuki366385 mongoloidkhulmikuki366385 mentioned this pull request Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeke zeke zeke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simpsoka @zeke