-
Notifications
You must be signed in to change notification settings - Fork 60.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extraneous grammar period which breaks the compare URL #1252
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
data/reusables/repositories/two-dot-diff-comparison-example-urls.md
Outdated
Show resolved
Hide resolved
…ls.md Co-authored-by: Nick Schonning <nschonni@gmail.com>
@idpbond Thanks so much for opening a PR and explaining your change so thoroughly! I'll get this triaged for review 🌟 |
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
This is not stale! Thanks for your patience @idpbond as our small team works through all of the amazing contributions 🌟 |
@janiceilene there is also a |
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@idpbond - many thanks for correcting this. 👍
Why:
Broken URL in the Comparing commits section due to a (grammatically correct) but UX-harmful period at the end.
What's being changed:
The period is being removed such that a user can copy + paste the example without encountering a "commit not found" UI on github. This improves the doc per the second list item here:
Check off the following: