Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous grammar period which breaks the compare URL #1252

Merged
merged 5 commits into from
Dec 2, 2020

Conversation

idpbond
Copy link
Contributor

@idpbond idpbond commented Nov 11, 2020

Why:

Broken URL in the Comparing commits section due to a (grammatically correct) but UX-harmful period at the end.

What's being changed:

The period is being removed such that a user can copy + paste the example without encountering a "commit not found" UI on github. This improves the doc per the second list item here:

Decisions aren’t about what’s right or wrong according to the rules of grammar or the style guide, but about what’s best for our users. We're flexible and open to change while maintaining consistency.

Check off the following:

@welcome
Copy link

welcome bot commented Nov 11, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

…ls.md

Co-authored-by: Nick Schonning <nschonni@gmail.com>
@janiceilene
Copy link
Contributor

@idpbond Thanks so much for opening a PR and explaining your change so thoroughly! I'll get this triaged for review 🌟

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 21, 2020
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Nov 23, 2020
@janiceilene
Copy link
Contributor

This is not stale! Thanks for your patience @idpbond as our small team works through all of the amazing contributions 🌟

@nschonni
Copy link
Contributor

@janiceilene there is also a never-stale label now to prevent the bot from tagging a PR

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 30, 2020
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idpbond - many thanks for correcting this. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team stale There is no recent activity on this issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants