Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify GH password requirements #1395

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Clarify GH password requirements #1395

merged 2 commits into from
Dec 2, 2020

Conversation

hongshaoyang
Copy link
Contributor

@hongshaoyang hongshaoyang commented Nov 17, 2020

Why:

Closes #1396 .

What's being changed:

The password requirements are missing the phrase "at least". Without this phrase, it seems like the password requirements must be exactly eight or 16 characters long.

Check off the following:

@welcome
Copy link

welcome bot commented Nov 17, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@hongshaoyang Thanks so much for opening a PR! I'll get this triaged for review 🌟

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Nov 17, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 28, 2020
@hongshaoyang
Copy link
Contributor Author

@janiceilene any updates on this PR?

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Nov 29, 2020
@janiceilene
Copy link
Contributor

@hongshaoyang Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨

@shati-patel shati-patel self-assigned this Dec 2, 2020
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your change, @hongshaoyang! We really appreciate all the community contributions to help improve our docs 😊

I'll get this merged shortly!

@shati-patel shati-patel merged commit 1d7acfa into github:main Dec 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@hongshaoyang hongshaoyang deleted the patch-1 branch December 2, 2020 15:27
@hongshaoyang
Copy link
Contributor Author

thanks @shati-patel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password requirements are misleading
3 participants