-
Notifications
You must be signed in to change notification settings - Fork 60.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LinkHeader link trailing slash #1503
Conversation
@nschonni Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
bc19f72
to
c4f7e0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nschonni - Thanks for fixing this. 👍
We really appreciate you taking the time to contribute to the documentation.
Thanks again!
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
* added create a fork * Update mst/aiven-client/create-fork.md Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> * incorporated changes suggested by Charis * Update mst/aiven-client/create-fork.md Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update mst/aiven-client/create-fork.md Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update mst/aiven-client/create-fork.md Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update mst/aiven-client/create-fork.md Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update mst/aiven-client/create-fork.md Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update mst/aiven-client/create-fork.md Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update mst/aiven-client/create-fork.md Co-authored-by: Lana Brindley <github@lanabrindley.com> * Update mst/aiven-client/create-fork.md Co-authored-by: Lana Brindley <github@lanabrindley.com> * incorporated the changes * updated the step to reflect the current install * fixed capitalization to make vale happy * making vale happy Co-authored-by: Charis <26616127+charislam@users.noreply.github.com> Co-authored-by: Lana Brindley <github@lanabrindley.com>
Why:
The page is on a Wiki, so the trailing slash meant it wasn't finding the page
What's being changed:
/
because the Wiki page shouldn't have itCheck off the following: