Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LinkHeader link trailing slash #1503

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Nov 20, 2020

Why:

The page is on a Wiki, so the trailing slash meant it wasn't finding the page

What's being changed:

  • Remove trailing / because the Wiki page shouldn't have it
  • Change to HTTPS
  • Remove the link suppression from tests now that it is fixed

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@nschonni nschonni requested a review from a team as a code owner November 20, 2020 16:32
@heiskr heiskr removed the request for review from a team November 20, 2020 19:36
@janiceilene
Copy link
Contributor

@nschonni Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added the content This issue or pull request belongs to the Docs Content team label Nov 20, 2020
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nschonni - Thanks for fixing this. 👍
We really appreciate you taking the time to contribute to the documentation.
Thanks again!

@hubwriter hubwriter merged commit 3d00a73 into github:main Dec 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@nschonni nschonni deleted the fix-linkheader branch December 2, 2020 17:50
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
* added create a fork

* Update mst/aiven-client/create-fork.md

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>

* incorporated changes suggested by Charis

* Update mst/aiven-client/create-fork.md

Co-authored-by: Lana Brindley <github@lanabrindley.com>

* Update mst/aiven-client/create-fork.md

Co-authored-by: Lana Brindley <github@lanabrindley.com>

* Update mst/aiven-client/create-fork.md

Co-authored-by: Lana Brindley <github@lanabrindley.com>

* Update mst/aiven-client/create-fork.md

Co-authored-by: Lana Brindley <github@lanabrindley.com>

* Update mst/aiven-client/create-fork.md

Co-authored-by: Lana Brindley <github@lanabrindley.com>

* Update mst/aiven-client/create-fork.md

Co-authored-by: Lana Brindley <github@lanabrindley.com>

* Update mst/aiven-client/create-fork.md

Co-authored-by: Lana Brindley <github@lanabrindley.com>

* Update mst/aiven-client/create-fork.md

Co-authored-by: Lana Brindley <github@lanabrindley.com>

* incorporated the changes

* updated the step to reflect the current install

* fixed capitalization to make vale happy

* making vale happy

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>
Co-authored-by: Lana Brindley <github@lanabrindley.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants