Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Links to localhost addresses #1505

Merged
merged 3 commits into from
Dec 15, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion content/developers/apps/authorizing-oauth-apps.md
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,9 @@ The optional `redirect_uri` parameter can also be used for localhost URLs. If th

For the `http://localhost/path` callback URL, you can use this `redirect_uri`:

http://localhost:1234/path
```
http://localhost:1234/path
```

### Creating multiple tokens for OAuth Apps

Expand Down
2 changes: 1 addition & 1 deletion content/developers/apps/using-content-attachments.md
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ To create a Probot App, follow these steps:
}
```

4. [Run the GitHub App locally](https://probot.github.io/docs/development/#running-the-app-locally). Navigate to [localhost:3000](http://localhost:3000), and click the **Register GitHub App** button:
4. [Run the GitHub App locally](https://probot.github.io/docs/development/#running-the-app-locally). Navigate to `http://localhost:3000`, and click the **Register GitHub App** button:

![Register a Probot GitHub App](/assets/images/github-apps/github_apps_probot-registration.png)

Expand Down
4 changes: 0 additions & 4 deletions lib/excluded-links.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ module.exports = [
'https://github.com/github/docs/edit',
'https://github.com/github/insights-releases/releases/latest',

// Developer content uses these for examples; they should not be checked.
'http://localhost:1234',
'localhost:3000',

// Oneoff links that link checkers think are broken but are not.
'https://haveibeenpwned.com/',
'https://www.ilo.org/dyn/normlex/en/f\\?p=NORMLEXPUB:12100:0::NO::P12100_ILO_CODE:P029'
Expand Down