Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The git commands here seems outdated. #1547

Closed
wants to merge 1 commit into from
Closed

The git commands here seems outdated. #1547

wants to merge 1 commit into from

Conversation

amhrn
Copy link

@amhrn amhrn commented Nov 22, 2020

Why: These git commands did not work for me, so I updated them accordingly.

What's being changed: Only 2 git commands in one file.

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

It did not work for me, so I updated it accordingly.
@welcome
Copy link

welcome bot commented Nov 22, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@mhrn77 Thanks so much for opening a PR! I'll get this triaged for review 🌟

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Nov 23, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Nov 30, 2020
@amhrn
Copy link
Author

amhrn commented Dec 1, 2020

Hope this minor change gets reviewed soon. Thanks.

@felicitymay
Copy link
Contributor

felicitymay commented Dec 1, 2020

👋🏻 Hi @mhrn77 I'm on the writing team at GitHub.

Thank you for telling us that you ran into trouble with the steps in this topic and for raising a PR to help other people avoid having the same problem.

Fairly recently we updated our topics to use main as the name for the default branch in line with our decision to use inclusive language.

I've just run through the steps in this topic and successfully added a dummy repository with a default branch of main. It seems as if my computer's set up differently from yours. I know it was a week or so ago that you had the problem, but do you have any information that would help us work out if there are any extra steps that some people need to use?

@github-actions github-actions bot removed the stale There is no recent activity on this issue or pull request label Dec 1, 2020
@amhrn
Copy link
Author

amhrn commented Dec 8, 2020

Hello @felicitymay,

Thanks for clearing that up. Sorry for the trouble.

@amhrn amhrn closed this Dec 8, 2020
@felicitymay
Copy link
Contributor

Hi @mhrn77 - no trouble.

Please continue to let us know where you find problems or room for improvement in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants