Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify CODEOWNERS syntax exceptions #1551

Merged
merged 6 commits into from
Dec 10, 2020
Merged

Clarify CODEOWNERS syntax exceptions #1551

merged 6 commits into from
Dec 10, 2020

Conversation

ajs256
Copy link
Contributor

@ajs256 ajs256 commented Nov 22, 2020 •
edited
Loading

Make it clearer that a CODEOWNERS file follows most, but not all, gitignore syntax rules to fix #1407

Why:

Fix #1407

What's being changed:

see diff

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@ajs256
Fix github#1407
d5f5502 
Say that a CODEOWNERS file follows most, but not all, gitignore syntax rules
@janiceilene
Copy link
Contributor

@ajs256 Thanks so much for opening a PR! I'll get this triaged for review 🌟

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Nov 23, 2020
hubwriter
hubwriter reviewed Dec 1, 2020
View reviewed changes
Copy link
Contributor

@hubwriter hubwriter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajs256 - Thanks for contributing this. 👍
I'd like to hold off on merging this just now and see if we can get some more detailed information on the CODEOWNERS syntax as a resolution for #1407. Let's see where we get with that.

Thanks again!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2020

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 8, 2020
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Dec 8, 2020
@ajs256
Copy link
Contributor Author

ajs256 commented Dec 8, 2020

bump

@ajs256 ajs256 mentioned this pull request Dec 9, 2020
Closed
@ajs256 ajs256 requested a review from hubwriter December 9, 2020 18:26
@janiceilene
Copy link
Contributor

Thanks for the update @ajs256! I'll get this re-triaged.

hubwriter
hubwriter reviewed Dec 10, 2020
View reviewed changes
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajs256 - Thanks for making this update, based on the information from @janiceilene

I like the way you've arranged the information. It's very clear.
Just one tiny suggestion: removal of a "."

If you agree and make this (or an alternative) change, I'll merge this.
Thanks again for pursuing and implementing this improvement.
Much appreciated. 👍

content/github/creating-cloning-and-archiving-repositories/about-code-owners.md Outdated Show resolved Hide resolved
ajs256 and others added 2 commits December 10, 2020 09:31
@ajs256 ajs256 changed the title Fix #1407 Clarify CODEOWNERS syntax exceptions Dec 10, 2020
@ajs256 ajs256 requested a review from hubwriter December 10, 2020 19:14
@hubwriter hubwriter merged commit 591b539 into github:main Dec 10, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@ajs256 ajs256 deleted the patch-2 branch December 10, 2020 20:07
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
@syvb
Add a missing backtick (github#1551)
9d8d5c1
@Chantall1602 Chantall1602 mentioned this pull request Oct 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubwriter hubwriter hubwriter approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Underdocumented CODEOWNERS syntax
3 participants
@ajs256 @janiceilene @hubwriter