Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libraries.md to include python client for GitHub's REST API that uses the OpenAPI Spec #1607

Merged
merged 2 commits into from
Dec 3, 2020
Merged

Update libraries.md to include python client for GitHub's REST API that uses the OpenAPI Spec #1607

merged 2 commits into from
Dec 3, 2020

Conversation

hamelsmu
Copy link
Contributor

@hamelsmu hamelsmu commented Nov 25, 2020 •
edited
Loading

Why:

Including a new python client that is using GitHub's newly published open api spec!

What's being changed:

Adding a new python client to the docs

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

cc: @jph00

@welcome
Copy link

welcome bot commented Nov 25, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@hamelsmu hamelsmu changed the title [WIP] Update libraries.md Update libraries.md to include python client for GitHub's REST API Nov 25, 2020
@hamelsmu hamelsmu marked this pull request as ready for review November 25, 2020 22:18
@hamelsmu hamelsmu changed the title Update libraries.md to include python client for GitHub's REST API Update libraries.md to include python client for GitHub's REST API that uses the OpenAPI Spec Nov 26, 2020
@dartie1987 dartie1987 mentioned this pull request Nov 27, 2020
Closed
@janiceilene
Copy link
Contributor

Thanks @hamelsmu! I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Nov 30, 2020
Pakphum100
Pakphum100 reviewed Dec 1, 2020
View reviewed changes
Copy link

@Pakphum100 Pakphum100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[https://globalpts.playtimes.com/windows/index.php?exchangeRate=&dateTimeZone=&token=2a1cbf4919eafd2b187ddef594218a3be990ef83&bankId=itp&playerId=UFAKKAH5008&gameId=00601001005](https://globalpts.playtimes.com/windows/index.php?exchangeRate=&dateTimeZone=&token=2a1cbf4919eafd2b187ddef594218a3be990ef83&bankId=itp&playerId=UFAKKAH5008&gameId=00601001005)

skedwards88
skedwards88 approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@skedwards88 skedwards88 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @hamelsmu ! I'll get it merged.

@skedwards88 skedwards88 merged commit 7672308 into main Dec 3, 2020
@skedwards88 skedwards88 deleted the hamelsmu-add-ghapi branch December 3, 2020 02:03
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pakphum100 Pakphum100 Pakphum100 left review comments

@dartie1987 dartie1987 dartie1987 approved these changes

@skedwards88 skedwards88 skedwards88 approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hamelsmu @janiceilene @skedwards88 @Pakphum100 @dartie1987