Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo sync #16442

Merged
merged 48 commits into from
Mar 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
a28305c
Updated language to reference enabling instead of opt-in
dihydroJenoxide Mar 17, 2022
52f7399
Optimize images
invalid-email-address Mar 17, 2022
e357b29
Merge branch 'main' into dihydrojen-4
dihydroJenoxide Mar 17, 2022
9385fcb
fixing broken link
dihydroJenoxide Mar 17, 2022
05d9ac5
Merge branch 'main' into dihydrojen-4
dihydroJenoxide Mar 17, 2022
8929c8c
Update content/get-started/privacy-on-github/about-githubs-use-of-you…
dihydroJenoxide Mar 21, 2022
219d719
Update content/get-started/privacy-on-github/managing-data-use-settin…
dihydroJenoxide Mar 22, 2022
cc96a78
Update content/get-started/privacy-on-github/managing-data-use-settin…
dihydroJenoxide Mar 22, 2022
3e35338
Merge branch 'main' into dihydrojen-4
dihydroJenoxide Mar 22, 2022
dea9e17
Merge pull request #26278 from github/dihydrojen-4
dihydroJenoxide Mar 22, 2022
e591ffe
Openapi update api.github.com (#26398)
rachmari Mar 22, 2022
dfe1692
Openapi 3.0 ghae (#26400)
rachmari Mar 22, 2022
e7c0463
Update OpenAPI Descriptions (#26397)
github-openapi-bot Mar 22, 2022
e177d70
Fix a change missed in a last minute update (#26389)
felicitymay Mar 22, 2022
a37f715
change order of some site-policy docs (#26307)
vollmera Mar 22, 2022
033f1fd
Merge branch 'main' into repo-sync
Octomerger Mar 22, 2022
80dd1c4
Merge pull request #26419 from github/repo-sync
Octomerger Mar 22, 2022
d68a2ee
Merge branch 'main' into repo-sync
Octomerger Mar 22, 2022
2fb0764
Merge pull request #26422 from github/repo-sync
Octomerger Mar 22, 2022
1ca669b
Create codespace.md
hubwriter Mar 22, 2022
1c10cf3
Merge branch 'main' into repo-sync
Octomerger Mar 22, 2022
bc2df17
Update README.md
hubwriter Mar 22, 2022
d58d577
Merge branch 'main' into repo-sync
docubot Mar 22, 2022
5d768e5
Update README.md
hubwriter Mar 22, 2022
a37127f
Update codespace.md
hubwriter Mar 22, 2022
c1da45f
Merge branch 'main' into repo-sync
docubot Mar 22, 2022
6ccb192
Update codespace.md
hubwriter Mar 22, 2022
32a8cf9
Merge branch 'main' into repo-sync
docubot Mar 22, 2022
8571dd7
Update codespace.md
hubwriter Mar 22, 2022
889aa27
Update codespace.md
hubwriter Mar 22, 2022
958abde
Merge branch 'main' into repo-sync
docubot Mar 22, 2022
21e276d
Merge pull request #26425 from github/repo-sync
Octomerger Mar 22, 2022
98daee0
Update OpenAPI Descriptions
github-openapi-bot Mar 22, 2022
250f63f
Merge branch 'main' into repo-sync
Octomerger Mar 22, 2022
669c66a
Merge pull request #26426 from github/repo-sync
Octomerger Mar 22, 2022
ed5362d
update preview env app_url to preview.ghdocs.com (#26335)
mikesurowiec Mar 22, 2022
2b66677
Fix flag (#26420)
mattpollard Mar 22, 2022
d92a0f2
Update codespace.md
hubwriter Mar 22, 2022
95d2d58
Update codespace.md
hubwriter Mar 22, 2022
4bac41a
Update codespace.md
hubwriter Mar 22, 2022
f6ec000
Remove Caddy from preview envs (#26336)
mikesurowiec Mar 22, 2022
6d6ba7f
Merge branch 'main' into repo-sync
Octomerger Mar 22, 2022
38c5724
Merge pull request #26428 from github/repo-sync
Octomerger Mar 22, 2022
ba3d251
Add `Ignore commits in the blame view` to blame docs (#26017)
JasonEtco Mar 22, 2022
a77a26a
Connect addendum deprecation (#26296)
birust Mar 22, 2022
3dd57f4
temporarily commented out
peterbe Mar 22, 2022
b89e458
also comment out
peterbe Mar 22, 2022
7f55632
also comment out
peterbe Mar 22, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/actions-scripts/get-preview-app-info.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
[[ -z $APP_NAME_SEED ]] && { echo "Missing APP_NAME_SEED. Exiting."; exit 1; }

PREVIEW_ENV_LOCATION="eastus"
echo "PREVIEW_ENV_LOCATION=${PREVIEW_ENV_LOCATION}" >> $GITHUB_ENV

REPO_NAME="${GITHUB_REPOSITORY#*\/}"
echo "REPO_NAME=${REPO_NAME}" >> $GITHUB_ENV
Expand All @@ -22,15 +21,14 @@ DEPLOYMENT_NAME="${REPO_NAME}-pr-${PR_NUMBER}"
echo "DEPLOYMENT_NAME=${DEPLOYMENT_NAME}" >> $GITHUB_ENV

APP_NAME_BASE="${REPO_NAME}-preview-${PR_NUMBER}"
echo "APP_NAME_BASE=${APP_NAME_BASE}" >> $GITHUB_ENV

# pseudo random string so guessing a preview env URL is more difficult
APP_SHA=$(echo -n "${APP_NAME_SEED}-${APP_NAME_BASE}" | sha1sum | cut -c1-6)

APP_NAME="${APP_NAME_BASE}-${APP_SHA}"
echo "APP_NAME=${APP_NAME}" >> $GITHUB_ENV

APP_URL="https://${APP_NAME}.${PREVIEW_ENV_LOCATION}.azurecontainer.io"
APP_URL="https://${REPO_NAME}-${PR_NUMBER}-${APP_SHA}.preview.ghdocs.com"
echo "APP_URL=${APP_URL}" >> $GITHUB_ENV

IMAGE_REPO="${GITHUB_REPOSITORY}/pr-${PR_NUMBER}"
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/azure-preview-env-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -203,13 +203,10 @@ jobs:
template: ./azure-preview-env-template.json
deploymentName: ${{ env.DEPLOYMENT_NAME }}
parameters: appName="${{ env.APP_NAME }}"
location="${{ env.PREVIEW_ENV_LOCATION }}"
containerImage="${{ env.DOCKER_IMAGE }}"
dockerRegistryUrl="${{ secrets.NONPROD_REGISTRY_SERVER }}"
dockerRegistryUsername="${{ secrets.NONPROD_REGISTRY_USERNAME }}"
dockerRegistryPassword="${{ secrets.NONPROD_REGISTRY_PASSWORD }}"
storageAccountName="${{ secrets.AZURE_STORAGE_ACCOUNT_NAME }}"
storageAccountKey="${{ secrets.AZURE_STORAGE_ACCOUNT_KEY }}"
# this shows warnings in the github actions console, because the flag is passed through a validation run,
# but it *is* functional during the actual execution
additionalArguments: --no-wait
31 changes: 15 additions & 16 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,14 @@ jobs:
fail-fast: false
matrix:
# The same array lives in test-windows.yml, so make any updates there too.
test-group:
[
test-group: [
content,
graphql,
meta,
rendering,
routing,
unit,
linting,
# linting,
translations,
]
steps:
Expand Down Expand Up @@ -102,20 +101,20 @@ jobs:
- name: Checkout LFS objects
run: git lfs checkout

- name: Gather files changed
uses: trilom/file-changes-action@a6ca26c14274c33b15e6499323aac178af06ad4b
id: get_diff_files
with:
# So that `steps.get_diff_files.outputs.files` becomes
# a string like `foo.js path/bar.md`
output: ' '
# - name: Gather files changed
# uses: trilom/file-changes-action@a6ca26c14274c33b15e6499323aac178af06ad4b
# id: get_diff_files
# with:
# # So that `steps.get_diff_files.outputs.files` becomes
# # a string like `foo.js path/bar.md`
# output: ' '

- name: Insight into changed files
run: |
# - name: Insight into changed files
# run: |

# Must to do this because the list of files can be HUGE. Especially
# in a repo-sync when there are lots of translation files involved.
echo "${{ steps.get_diff_files.outputs.files }}" > get_diff_files.txt
# # Must to do this because the list of files can be HUGE. Especially
# # in a repo-sync when there are lots of translation files involved.
# echo "${{ steps.get_diff_files.outputs.files }}" > get_diff_files.txt

- name: Setup node
uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561
Expand All @@ -137,6 +136,6 @@ jobs:

- name: Run tests
env:
DIFF_FILE: get_diff_files.txt
# DIFF_FILE: get_diff_files.txt
CHANGELOG_CACHE_FILE_PATH: tests/fixtures/changelog-feed.json
run: npm test -- tests/${{ matrix.test-group }}/
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
64 changes: 0 additions & 64 deletions azure-preview-env-template.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
"description": "A unique name for the app"
}
},
"location": {
"type": "String"
},
"containerImage": {
"type": "string",
"defaultValue": null,
Expand All @@ -32,12 +29,6 @@
},
"dockerRegistryPassword": {
"type": "SecureString"
},
"storageAccountName": {
"type": "String"
},
"storageAccountKey": {
"type": "SecureString"
}
},
"resources": [
Expand Down Expand Up @@ -83,53 +74,6 @@
}
}
}
},
{
"name": "caddy-ssl-server",
"properties": {
"image": "caddy:2.4.6",
"command": [
"caddy",
"reverse-proxy",
"--from",
"[concat(parameters('appName'), '.', parameters('location'), '.azurecontainer.io')]",
"--to",
"localhost:4000"
],
"ports": [
{
"protocol": "TCP",
"port": 443
},
{
"protocol": "TCP",
"port": 80
}
],
"environmentVariables": [],
"resources": {
"requests": {
"memoryInGB": 1,
"cpu": 1
}
},
"volumeMounts": [
{
"name": "caddy-data",
"mountPath": "/data"
}
]
}
}
],
"volumes": [
{
"name": "caddy-data",
"azureFile": {
"shareName": "caddy",
"storageAccountName": "[parameters('storageAccountName')]",
"storageAccountKey": "[parameters('storageAccountKey')]"
}
}
],
"imageRegistryCredentials": [
Expand All @@ -142,17 +86,9 @@
"restartPolicy": "Always",
"ipAddress": {
"ports": [
{
"protocol": "TCP",
"port": 443
},
{
"protocol": "TCP",
"port": 4000
},
{
"protocol": "TCP",
"port": 80
}
],
"type": "Public",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ You'll see updates in your news feed when a user you follow:
- Forks a public repository.{% endif %}
- Publishes a new release.

For more information about starring repositories and following people, see "[Following people](/articles/following-people)" and "[Be social](/get-started/quickstart/be-social)."
For more information about following people and watching repositories, see "[Following people](/get-started/exploring-projects-on-github/following-people)" and "[Be social](/get-started/quickstart/be-social)."

{% if for-you-feed %}
### For you feed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ shortTitle: GitHub's use of your data

## About {% data variables.product.product_name %}'s use of your data

{% data variables.product.product_name %} aggregates metadata and parses content patterns for the purposes of delivering generalized insights within the product. It uses data from public repositories, and also uses metadata and aggregate data from private repositories when a repository's owner has chosen to share the data with {% data variables.product.product_name %} through an opt-in. If you opt a private repository into data use, then it will perform read-only analysis of that specific private repository.
{% data variables.product.product_name %} aggregates metadata and parses content patterns for the purposes of delivering generalized insights within the product. It uses data from public repositories, and also uses metadata and aggregate data from private repositories when a repository's owner has chosen to share the data with {% data variables.product.product_name %} by enabling the dependency graph. If you enable the dependency graph for a private repository, then {% data variables.product.product_name %} will perform read-only analysis of that specific private repository.

If you enable data use for a private repository, we will continue to treat your private data, source code, or trade secrets as confidential and private consistent with our [Terms of Service](/free-pro-team@latest/github/site-policy/github-terms-of-service). The information we learn only comes from aggregated data. For more information, see "[Managing data use settings for your private repository](/get-started/privacy-on-github/managing-data-use-settings-for-your-private-repository)."

{% data reusables.repositories.about-github-archive-program %} For more information, see "[About archiving content and data on {% data variables.product.prodname_dotcom %}](/github/creating-cloning-and-archiving-repositories/about-archiving-content-and-data-on-github#about-the-github-archive-program)."

{% data reusables.user-settings.export-data %} For more information, see "[Requesting an archive of your personal account's data](/articles/requesting-an-archive-of-your-personal-account-s-data)."

If you opt in to data use for a private repository, we will continue to treat your private data, source code, or trade secrets as confidential and private consistent with our [Terms of Service](/free-pro-team@latest/github/site-policy/github-terms-of-service). The information we learn only comes from aggregated data. For more information, see "[Managing data use settings for your private repository](/get-started/privacy-on-github/managing-data-use-settings-for-your-private-repository)."

We'll announce substantial new features that use metadata or aggregate data on the [{% data variables.product.prodname_dotcom %} blog](https://github.com/blog).

## How data improves security recommendations
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,22 @@ shortTitle: Manage data use for private repo

## About data use for your private repository


You can control data use for your private repository with the security and analysis features.

- Enable the dependency graph to allow read-only data analysis on your repository.
- Disable the dependency graph to block read-only data analysis of your repository.

When you enable data use for your private repository, you'll be able to access the dependency graph, where you can track your repository's dependencies and receive {% data variables.product.prodname_dependabot_alerts %} when {% data variables.product.product_name %} detects vulnerable dependencies. For more information, see "[About {% data variables.product.prodname_dependabot_alerts %}](/github/managing-security-vulnerabilities/about-alerts-for-vulnerable-dependencies#dependabot-alerts-for-vulnerable-dependencies)."

## Enabling or disabling data use features

{% note %}

**Note:** If you disable the dependency graph, {% data variables.product.prodname_dependabot_alerts %} and {% data variables.product.prodname_dependabot_security_updates %} are also disabled. For more information, see "[About the dependency graph](/code-security/supply-chain-security/understanding-your-software-supply-chain/about-the-dependency-graph)."

{% endnote %}

## Enabling or disabling data use through security and analysis features

{% data reusables.security.security-and-analysis-features-enable-read-only %}

Expand Down
Loading