Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(graphql): order token scopes by form order #16715

Merged
merged 3 commits into from
May 24, 2022

Conversation

Bamblehorse
Copy link
Contributor

Why:

The order of the scopes on the Forming calls with GraphQL page is not the same as the order of the form to create a personal access token.

It might also be useful to remove repo from the list - as it implies checking all the nested repo boxes.

A second useful clarification here might be documenting the parent scope as well as the child scope - to allow for easy scanning.

Scope order on Forming calls with GraphQL page

image

https://docs.github.com/en/graphql/guides/forming-calls-with-graphql

Scope order on create a personal access token page

github com_settings_tokens_new

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Mar 31, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
graphql/guides/forming-calls-with-graphql.md fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae
fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae

@Bamblehorse Bamblehorse changed the title docs: order token scopes by form order docs(graphql): order token scopes by form order Mar 31, 2022
@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review graphql Content related to GraphQL and removed triage Do not begin working on this issue until triaged by the team labels Mar 31, 2022
@ramyaparimi
Copy link
Contributor

@Bamblehorse
Thanks so much for opening a PR! I'll get this triaged for review ⚡

Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me! We'll get this merged down for you.

@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label May 23, 2022
@skedwards88 skedwards88 enabled auto-merge (squash) May 23, 2022 21:38
@skedwards88 skedwards88 merged commit 0116138 into github:main May 24, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team graphql Content related to GraphQL ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants