-
Notifications
You must be signed in to change notification settings - Fork 60.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(graphql): order token scopes by form order #16715
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
|
@Bamblehorse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable to me! We'll get this merged down for you.
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
The order of the scopes on the Forming calls with GraphQL page is not the same as the order of the form to create a personal access token.
It might also be useful to remove
repo
from the list - as it implies checking all the nested repo boxes.A second useful clarification here might be documenting the parent scope as well as the child scope - to allow for easy scanning.
Scope order on Forming calls with GraphQL page
https://docs.github.com/en/graphql/guides/forming-calls-with-graphql
Scope order on create a personal access token page
What's being changed:
Check off the following:
Writer impact (This section is for GitHub staff members only):