Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace "Github" with "GitHub" #17140

Closed
wants to merge 1 commit into from
Closed

fix: replace "Github" with "GitHub" #17140

wants to merge 1 commit into from

Conversation

xlgmokha
Copy link
Contributor

@xlgmokha xlgmokha commented Apr 16, 2022

Why:

The brand name GitHub uses an upper case letter H. This is the same for all languages.

What's being changed:

This change updates usages of Github to GitHub to match the brand.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions
Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
lib/search/indexes/**
package*.json
scripts/**
translations/**
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 16, 2022
@xlgmokha xlgmokha marked this pull request as ready for review April 16, 2022 18:07
@xlgmokha xlgmokha requested review from a team and Octomerger as code owners April 16, 2022 18:07
@ramyaparimi ramyaparimi added localization Issue or PR relating to translation or localization and removed triage Do not begin working on this issue until triaged by the team labels Apr 18, 2022
@ramyaparimi
Copy link
Contributor

@xlgmokha
Thanks for opening this! Unfortunately, we are not able to accept changes for translated content. Our translation process involves an integration with an external service at crowdin.com, where all translation activity happens. We hope to eventually open up the translation process to the open-source community, but we're not there yet.

See https://github.com/github/docs/blob/main/contributing/types-of-contributions.md#earth_asia-translations.

@xlgmokha xlgmokha deleted the xlg/fix-casing-of-github-brand branch April 19, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Issue or PR relating to translation or localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants