Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify page that will actually have user settings #18659

Closed
wants to merge 1 commit into from
Closed

specify page that will actually have user settings #18659

wants to merge 1 commit into from

Conversation

hamirmahal
Copy link
Contributor

Why:

Closes #18657

What's being changed:

I added an example of a page that should actually have user settings that are easily accessible to readers.

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 15, 2022
I saw `data/reusables/user-settings/access_settings.md` at https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token#creating-a-token.

That article said,
> In the upper-right corner of **any** page, click your profile photo, then click Settings.

The page that article was on did not have a user icon in the top righthand corner.
@osfanbuff63
Copy link
Contributor

Should probably use the variable for GitHub.com here ({% data variables.product.prodname_dotcom %})

@janiceilene
Copy link
Contributor

@hamirmahal Thanks so much for opening a PR! Since all of the procedurals where we use this reusable are instructions for how to do something on any GitHub page, we don't need to include a URL. I'm going to close this PR 💛

Thanks for your interest and passion in improving the GitHub Docs ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify a page that will actually have user settings accessible in the top righthand corner
3 participants