-
Notifications
You must be signed in to change notification settings - Fork 60.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Emoji-cheat-sheet link #1993
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@Andre601 Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
Is this still being checked? |
It is! Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨ |
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
Yes GitHub Actions, this PR is still active. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
content/github/writing-on-github/basic-writing-and-formatting-syntax.md
I mentioned this before and I mention this again: I and probably anyone else following this PR would appreciate it, if you wouldn't make PR approvals over and over again. While this was just one approval this time was it still not nesessary to do as there were no changes whatsoever that justified it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change @Andre601 and I'm so sorry it got hit with spammers 💛 I'll update the branch and get this merged once all tests are passing!
That's okay as long as those people are dealt with. I reported one user already and also gave the support-team the hint, that they should also check out the other users I mentioned, so hopefully those people will be gone soon enough. I honestly wish I would understand even half of all the checks/actions made on this PR 😅 |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
Why:
closes #1992
While I did explain in the above issue why, will I still say the reason here for the sake or documentation.
The doc page explaining emojis links to https://emoji-cheat-sheet.com, while the Guide about GFM and emojis is linking to a repository which seems to be updated.
Since people may get to the docs through the guide would those two different URLs only cause confusion as to which one to look at for up-to-date info.
I now changed the link to point to the aforementioned repository as there is no guarantee (unless GitHub would do this) that the Guide would be updated AND that the emoji-cheat-sheet page only shows emojis supported on GitHub and not also extra ones not available here.
What's being changed:
Section "Using Emojis" of
content/github/writing-on-github/basic-writing-and-formatting-syntax.md
Diff:
Check off the following: