Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update about-saml-for-enterprise-iam.md #20012

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Conversation

EMILYMC0
Copy link
Contributor

@EMILYMC0 EMILYMC0 commented Aug 20, 2022

This is linked to this Issue: Inconsistency between SCIM support #11639

Why:

Closes 11639

What's being changed (if available, include any code snippets, screenshots, or gifs):

image

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

This is linked to this Issue: Inconsistency between SCIM support github#11639
@welcome
Copy link

welcome bot commented Aug 20, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 20, 2022
@EMILYMC0 EMILYMC0 marked this pull request as ready for review August 20, 2022 15:23
@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2022

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
admin/identity-and-access-management/using-saml-for-enterprise-iam/about-saml-for-enterprise-iam.md ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@EMILYMC0 Thanks so much for opening a PR! I made a slight edit to link your PR to the issue.

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Aug 22, 2022
Copy link
Contributor

@sophietheking sophietheking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @EMILYMC0 👋 Thanks for opening this PR! We really appreciate it. 💖

This change looks good to me. I'll get this merged for you! 🚀

@sophietheking sophietheking added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Aug 23, 2022
@sophietheking sophietheking merged commit f7cd515 into github:main Aug 23, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@lecoursen
Copy link
Member

👋🏻 we actually already document the fact that SCIM is not supported at the enterprise-level unless you use EMUs in the note box 2 paragraphs down. We don't use the phrase "non-EMU SAML" in the Docs so I'm going to go ahead and revert this change. Sorry for the confusion here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency between SCIM support
4 participants