Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions: Add examples for shells other than Bash #2121

Closed
wants to merge 5 commits into from
Closed

Actions: Add examples for shells other than Bash #2121

wants to merge 5 commits into from

Conversation

Simran-B
Copy link
Contributor

Why:

#253

What's being changed:

  • Add examples for PowerShell Core, Windows cmd and Python
  • Unify headlines of existing examples
    • bash = Bash
    • pwsh = PowerShell Core
    • cmd = Windows cmd
    • python = Python
  • Minor markup improvements

Check off the following:

  • All of the tests are passing.
  • I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
  • For content changes, I have reviewed the localization checklist
  • For content changes, I have reviewed the Content style guide for GitHub Docs.

@Simran-B
Table formatting
408a66d
@Simran-B
Unify headlines
6bb9f23 
bash = Bash
pwsh = PowerShell Core
cmd = Windows `cmd`
python = Python
@Simran-B
Env vars: Add pwsh, cmd and python examples
94a64a1
@Simran-B Simran-B mentioned this pull request Dec 15, 2020
Closed
@Simran-B
Copy link
Contributor Author

Simran-B commented Dec 15, 2020 •
edited
Loading

Notes to self:

  • Need to test YAML examples in content\actions\reference\workflow-commands-for-github-actions.md with different shells.
  • Is it necessary to call os.path.normpath() in Python examples if that paths are specified with forward slashes and we write to GITHUB_PATH env var?
  • Is there syntax highlighting available for Windows Batch scripts? ```batch is not available:
    Error: Unknown language: `batch` is not registered

@janiceilene
Copy link
Contributor

@Simran-B Let me know when you're ready for reviews ✨

@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 23, 2020
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Dec 23, 2020
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 31, 2020
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 4, 2021
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 11, 2021
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 11, 2021
@github-actions
Copy link
Contributor

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Jan 19, 2021
@janiceilene
Copy link
Contributor

@Simran-B I'm going to toss a never-stale label on this one, then you can ping me when you're ready for review without getting stale pings while you're working on it ⚡

@janiceilene janiceilene added never-stale Do not close as stale and removed stale There is no recent activity on this issue or pull request labels Jan 19, 2021
@janiceilene janiceilene added the waiting for review Issue/PR is waiting for a writer's review label Feb 5, 2021
@github-actions github-actions bot closed this Feb 13, 2021
@janiceilene
Copy link
Contributor

janiceilene commented Feb 16, 2021 •
edited
Loading

It looks like our new action inadvertently closed this 🙃 Sorry about that! Reopening 💛

@janiceilene janiceilene reopened this Feb 16, 2021
@janiceilene janiceilene removed the waiting for review Issue/PR is waiting for a writer's review label Feb 16, 2021
@github-actions
Copy link
Contributor

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Feb 24, 2021
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Feb 26, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2021

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Mar 6, 2021
@github-actions github-actions bot closed this Mar 9, 2021
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Mar 16, 2021
@janiceilene
Copy link
Contributor

😭 Stop it stalebot!

@janiceilene janiceilene reopened this Mar 16, 2021
@github-actions
Copy link
Contributor

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Mar 24, 2021
@janiceilene janiceilene added waiting for review Issue/PR is waiting for a writer's review and removed stale There is no recent activity on this issue or pull request labels Mar 25, 2021
@github-actions github-actions bot removed the waiting for review Issue/PR is waiting for a writer's review label Mar 26, 2021
@Simran-B Simran-B mentioned this pull request Apr 8, 2021
Closed
@Simran-B
Copy link
Contributor Author

Simran-B commented Apr 8, 2021

Having a headline above each example for every shell type is pretty messy. My idea was to use tabs, but that's apparently not going anywhere (#1606 (comment)). I'm waiting for an alternative.

roythearsonist
roythearsonist approved these changes Apr 30, 2021
View reviewed changes
Copy link

@roythearsonist roythearsonist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

SirJosh1987
SirJosh1987 reviewed Jul 31, 2021
View reviewed changes
content/actions/reference/environment-variables.md Outdated
```yaml
steps:
- name: Hello world
shell: bash
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bashhh

@SirJosh1987
Copy link

I really need one on one help

@ramyaparimi
Copy link
Contributor

@Simran-B Just checking to see if you have any update on this PR 😄

@DoctorSky1967
Copy link

DoctorSky1967 commented Aug 5, 2021 via email

@janiceilene
Copy link
Contributor

Thanks so much for working on this PR! It looks like work is paused, so I'm going to close the PR to remove it from our actively tracked backlog. If you'd like to continue work on it at anytime please let us know and we'll be happy to reopen it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roythearsonist roythearsonist roythearsonist approved these changes

@SirJosh1987 SirJosh1987 SirJosh1987 approved these changes

@DoctorSky1967 DoctorSky1967 DoctorSky1967 approved these changes

Assignees
No one assigned
Labels
never-stale Do not close as stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Simran-B @janiceilene @SirJosh1987 @ramyaparimi @DoctorSky1967 @roythearsonist