Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use English for event names #224

Closed
wants to merge 1 commit into from

Conversation

toshimaru
Copy link

@toshimaru toshimaru commented Oct 8, 2020

Why:

Translations for event names are not needed.
So, use English event names instead of Japanese.

What's being changed:

  • Translated headings
  • Translated webhook payload names
Before

image

After ワークフローをトリガーするイベント_-_GitHub_Docs

Check off the following:

@welcome
Copy link

welcome bot commented Oct 8, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@toshimaru toshimaru marked this pull request as ready for review October 8, 2020 00:45
@toshimaru toshimaru requested a review from a team as a code owner October 8, 2020 00:45
Translations for event names are not needed.
So, use English event names
@zeke
Copy link
Contributor

zeke commented Oct 8, 2020

Thanks for opening this pull request @toshimaru!

Unfortunately, we are not able to accept pull requests for translated content. Our translation process involves an integration with an external service at crowdin.com, where all translation activity happens. We hope to eventually open up the translation process to the open-source community, but we're not there yet. See https://github.com/github/docs/blob/main/CONTRIBUTING.md#earth_asia-translations for more details.

I have opened an issue in our internal localization tracking repo with a link to the changes you've proposed here, and we'll make sure our translators get this fixed soon.

Thanks again!

@zeke zeke closed this Oct 8, 2020
@zeke zeke added the localization Issue or PR relating to translation or localization label Oct 8, 2020
@toshimaru toshimaru deleted the update-ja-trigger-workflows branch October 20, 2020 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization Issue or PR relating to translation or localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants