Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganized changing commit message docs #229

Merged
merged 4 commits into from
Oct 8, 2020
Merged

Reorganized changing commit message docs #229

merged 4 commits into from
Oct 8, 2020

Conversation

Ruth-ikegah
Copy link
Contributor

@Ruth-ikegah Ruth-ikegah commented Oct 8, 2020 •
edited
Loading

Why:

Fixes Issue #158 as suggested by the author

What's being changed:

The file was reorganized following the content plan on issue #158

Check off the following:

@welcome
Copy link

welcome bot commented Oct 8, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

janiceilene
janiceilene requested changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @Ruth-ikegah Thanks for opening an issue and tackling this PR 💖 It looks great! I left one comment that you should fix up and then we'll get this merged in!

content/github/committing-changes-to-your-project/changing-a-commit-message.md Outdated Show resolved Hide resolved
janiceilene
janiceilene approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wonderful @Ruth-ikegah 💝 I'll merge it as soon as everything's green 👍

@janiceilene janiceilene merged commit cf710b7 into github:main Oct 8, 2020
@janiceilene
Copy link
Contributor

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

@allcontributors allcontributors bot mentioned this pull request Oct 9, 2020
Merged
@allcontributors
Copy link
Contributor

@Ruth-ikegah

I've put up a pull request to add @ruth! 🎉

@Ruth-ikegah
Copy link
Contributor Author

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

Thanks!! Done!

@Ruth-ikegah
Copy link
Contributor Author

@all-contributors please add @Ruth-ikegah for Documentation

@allcontributors
Copy link
Contributor

@Ruth-ikegah

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@Ruth-ikegah
Copy link
Contributor Author

@all-contributors please add @Ruth-ikegah for docs

@allcontributors allcontributors bot mentioned this pull request Oct 9, 2020
Closed
@allcontributors
Copy link
Contributor

@Ruth-ikegah

I've put up a pull request to add @Ruth-ikegah! 🎉

@janiceilene janiceilene mentioned this pull request Oct 9, 2020
Closed
@Ruth-ikegah
Copy link
Contributor Author

Hi @janiceilene I initially made a mistake with adding my name as a contributor. When I noticed, I made a new comment, so two PRs were made by all-contributors. And I just noticed the first one which was a mistake was merged(not my GitHub account). And the second one which is the correct was not. It's still open as a PR though. Please how do I resolve this

@janiceilene
Copy link
Contributor

Oh no! I'm so sorry @Ruth-ikegah I didn't realize I merged the wrong one 💛 I'll work on getting this fixed up.

@Ruth-ikegah
Copy link
Contributor Author

Oh no! I'm so sorry @Ruth-ikegah I didn't realize I merged the wrong one 💛 I'll work on getting this fixed up.

It's fine. Thanks so much!

@Ruth-ikegah Ruth-ikegah mentioned this pull request Oct 15, 2020
Closed
This was referenced Jan 21, 2021
Open
Open
@rhsayem075 rhsayem075 mentioned this pull request Jan 26, 2021
Open
This was referenced Jan 27, 2021
Open
Open
Open
@YoYBaBy YoYBaBy mentioned this pull request Feb 3, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jul 21, 2022
Open
This was referenced Aug 7, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Aug 25, 2022
Open
@rexingQ rexingQ mentioned this pull request Sep 2, 2022
Open
This was referenced Sep 19, 2022
Open
Open
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
@Loquacity @mirandaauhl
404 fixes (github#229)
87e1e4d 
* New issues from Moz, plus some general tidy-up

* Issue github#222

* Issue github#215 & remove unused links

* Others from Moz

* Moar 404s, syntax, etc.

* make fixing changes to links

Co-authored-by: Miranda Auhl <miranda@timescale.com>
Co-authored-by: Ryan Booz <ryan@timescale.com>
@snyk-bot snyk-bot mentioned this pull request Oct 11, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Nov 13, 2022
Open
This was referenced Nov 27, 2022
Open
Merged
@zongruxie73 zongruxie73 mentioned this pull request Jun 5, 2023
Open
@silkchamberlin silkchamberlin mentioned this pull request Feb 20, 2024
Open
@Nahom1927 Nahom1927 mentioned this pull request Mar 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janiceilene janiceilene janiceilene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ruth-ikegah @janiceilene