Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated quickstart.md typos #241

Closed
wants to merge 1 commit into from
Closed

Updated quickstart.md typos #241

wants to merge 1 commit into from

Conversation

Shivam7-1
Copy link
Contributor

@Shivam7-1 Shivam7-1 commented Oct 8, 2020

Why: This is fixing the typos in quickstart.md

What's being changed:

In there I have added in sentence which require the ( . ) at the end of the sentence

Check off the following:

@Shivam7-1
Copy link
Contributor Author

@janiceilene
Copy link
Contributor

janiceilene commented Oct 8, 2020

Thanks @Shivam7-1! Please fill out the PR template, so we can review this.

@janiceilene janiceilene closed this Oct 8, 2020
@janiceilene janiceilene reopened this Oct 8, 2020
Copy link
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Shivam7-1! Since the individual bullets don't include complete sentences, we don't add a period at the end. There's a great example in the GitHub Brand Guide.

@janiceilene janiceilene closed this Oct 9, 2020
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
* broken link checker

* refactor pr-creation.yml to include broken link checker

* retrigger

* trigger

* create own action

* update yaml

* tweak yaml

* set recursive links true

* test on production site

* try links.yml

* update links.yml

* exclude local host

* yaml fix

* make link search manual

* remove google and github crawler block

* remove trigger

* expand list of acceptable broken links

* remove line from yml

* remove broken link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants