Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screenshot update for settings directory #24668

Merged
merged 10 commits into from
Apr 6, 2023
Merged

Screenshot update for settings directory #24668

merged 10 commits into from
Apr 6, 2023

Conversation

OlayinkaAtobiloye
Copy link
Contributor

@OlayinkaAtobiloye OlayinkaAtobiloye commented Mar 25, 2023 •
edited
Loading

Why:

Closes: #23967

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 25, 2023
@OlayinkaAtobiloye
Copy link
Contributor Author

Hi, @cmwilson21! I did some accessibility updates for the setting directory. Please check this out when chanced!✨

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2023 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
apps/publishing-apps-to-github-marketplace/listing-an-app-on-github-marketplace/drafting-a-listing-for-your-app.md fpt
ghec
 fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21 cmwilson21 self-requested a review March 28, 2023 14:50
@cmwilson21 cmwilson21 removed the triage Do not begin working on this issue until triaged by the team label Mar 28, 2023
sabrowning1
sabrowning1 reviewed Mar 30, 2023
View reviewed changes
Copy link
Contributor

@sabrowning1 sabrowning1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @OlayinkaAtobiloye! Thanks for your work on this ✨ just a few minor suggestions for variables 🙂

...o-github-marketplace/listing-an-app-on-github-marketplace/drafting-a-listing-for-your-app.md Outdated Show resolved Hide resolved
data/reusables/apps/settings-step.md Outdated Show resolved Hide resolved
data/reusables/user-settings/github_apps.md Outdated Show resolved Hide resolved
data/reusables/user-settings/marketplace_apps.md Outdated Show resolved Hide resolved
OlayinkaAtobiloye and others added 4 commits March 31, 2023 17:07
@OlayinkaAtobiloye @sabrowning1
Update content/apps/publishing-apps-to-github-marketplace/listing-an-…
8bb370c 
…app-on-github-marketplace/drafting-a-listing-for-your-app.md

Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
@OlayinkaAtobiloye @sabrowning1
Update data/reusables/apps/settings-step.md
1bba1ef 
Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
@OlayinkaAtobiloye @sabrowning1
Update data/reusables/user-settings/marketplace_apps.md
2f513ad 
Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
@OlayinkaAtobiloye @sabrowning1
Update data/reusables/user-settings/github_apps.md
9b2833d 
Co-authored-by: Sam Browning <106113886+sabrowning1@users.noreply.github.com>
cmwilson21
cmwilson21 previously approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@cmwilson21 cmwilson21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OlayinkaAtobiloye for the updates and @sabrowning1 for the review! I'll get this merged down! 💖

@cmwilson21 cmwilson21 added this pull request to the merge queue Apr 6, 2023
Merged via the queue into github:main with commit 66cae22 Apr 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabrowning1 sabrowning1 sabrowning1 left review comments

@cmwilson21 cmwilson21 cmwilson21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MLH Fellow content update (images)
3 participants
@OlayinkaAtobiloye @cmwilson21 @sabrowning1