Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified information on excluding results from searches #24669

Merged
merged 5 commits into from
Mar 29, 2023

Conversation

OlayinkaAtobiloye
Copy link
Contributor

Why:

Closes: #23461

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
search-github/getting-started-with-searching-on-github/understanding-the-search-syntax.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

nababatiguza

This comment was marked as spam.

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team search-github Related to GitHub search waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Mar 27, 2023
@cmwilson21
Copy link
Contributor

👋 @OlayinkaAtobiloye Thanks so much for opening a PR! I'll get this triaged for review ⚡ ✨

Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OlayinkaAtobiloye - thank you for finding time to address this issue 💖

I've made a couple of small suggestions. Once you've had a look and updated the PR, we check the preview looks okay, and merge the PR.

OlayinkaAtobiloye and others added 2 commits March 28, 2023 22:52
…/understanding-the-search-syntax.md

Co-authored-by: Felicity Chapman <felicitymay@github.com>
…/understanding-the-search-syntax.md

Co-authored-by: Felicity Chapman <felicitymay@github.com>
@OlayinkaAtobiloye
Copy link
Contributor Author

Contributor

Hi @felicitymay! Thanks for the review! Thanks for the feedback - really helpful! They've all been applied now.✨

@felicitymay
Copy link
Contributor

Thanks for committing the suggestions @OlayinkaAtobiloye

When you updated from main, it looks as if this brought in a recent table update for accessibility that conflicted with one of the changes that I suggested, so I've resolved the conflict. If all looks good after that, we can merge this PR.

My apologies @OlayinkaAtobiloye - correcting the conflict resolution.
@felicitymay
Copy link
Contributor

Thanks for your work on this @OlayinkaAtobiloye 💖

This looks ready to merge.

@felicitymay felicitymay enabled auto-merge (squash) March 29, 2023 07:50
@felicitymay felicitymay added the ready to merge This pull request is ready to merge label Mar 29, 2023
@felicitymay felicitymay merged commit ddef2bb into github:main Mar 29, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@dxodja

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge search-github Related to GitHub search waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify information on excluding results from searches
5 participants