Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention dependency name for docker image tags #24736

Merged
merged 7 commits into from
Apr 4, 2023

Conversation

cvirtucio
Copy link
Contributor

@cvirtucio cvirtucio commented Mar 28, 2023

Why:

Closes: #24735

What's being changed (if available, include any code snippets, screenshots, or gifs):

The dependency-name section in this subheader will look like this:

Screenshot 2023-03-28 at 2 46 50 PM

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Mar 28, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cvirtucio cvirtucio marked this pull request as ready for review March 28, 2023 19:03
@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review dependabot Content related to Dependabot code security Content related to code security and removed triage Do not begin working on this issue until triaged by the team labels Mar 30, 2023
@cmwilson21
Copy link
Contributor

@cvirtucio Thank you for opening a PR and linking it to your issue! ✨

I'll get this triaged for review! ⚡

@mchammer01 mchammer01 added the needs SME This proposal needs review from a subject matter expert label Mar 30, 2023
@github-actions
Copy link
Contributor

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

@mchammer01
Copy link
Contributor

Thanks for the technical review @deivid-rodriguez
I'll review this on behalf of Docs now.

@mchammer01 mchammer01 self-requested a review April 4, 2023 12:56
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cvirtucio 👋🏻 - thanks for improving our docs ✨
I'll approve your PR once I've committed minor improvements that I've suggested from an editorial point of view 😃

…nfiguration-options-for-the-dependabot.yml-file.md
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@mchammer01 mchammer01 added this pull request to the merge queue Apr 4, 2023
Merged via the queue into github:main with commit 07f7e92 Apr 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code security Content related to code security content This issue or pull request belongs to the Docs Content team dependabot Content related to Dependabot needs SME This proposal needs review from a subject matter expert waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mention dependency-name for docker image tags
4 participants