Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak grammar and punctuation for clarity #25630

Merged
merged 2 commits into from
May 24, 2023
Merged

tweak grammar and punctuation for clarity #25630

merged 2 commits into from
May 24, 2023

Conversation

TallTed
Copy link
Contributor

@TallTed TallTed commented May 18, 2023

Why:

Observed incorrect grammar and punctuation.

What's being changed (if available, include any code snippets, screenshots, or gifs):

A few words and punctuation marks.

Check off the following:

@welcome
Copy link

welcome bot commented May 18, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 18, 2023
@cmwilson21
Copy link
Contributor

@TallTed Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team contributing docs Content related to our contributing docs waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels May 19, 2023
Copy link
Contributor

@sabrowning1 sabrowning1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TallTed thanks so much for finding these grammatical errors and opening a PR! ✨ I've made a few changes below; please let me know when you've committed them and I'll get this merged.

contributing/translations-for-writers.md Outdated Show resolved Hide resolved
contributing/translations-for-writers.md Outdated Show resolved Hide resolved
contributing/translations-for-writers.md Outdated Show resolved Hide resolved
Copy link
Contributor

@sabrowning1 sabrowning1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏼 @TallTed, thanks again for your help with these grammatical errors! I've applied my suggestions and will go ahead and merge this to get these errors fixed 🙂 if you have any questions on my changes, feel free to take a look at the notes I left in my comments.

Thank you for your help maintaining our docs! ✨

@sabrowning1 sabrowning1 added this pull request to the merge queue May 24, 2023
Merged via the queue into github:main with commit f645d2d May 24, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@TallTed
Copy link
Contributor Author

TallTed commented Jun 5, 2023

Your comments and merge came through while I was on holiday. Let me know whether you want a new PR for my comments above, or you prefer to apply them directly.

@TallTed TallTed deleted the patch-1 branch June 5, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team contributing docs Content related to our contributing docs waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants