-
Notifications
You must be signed in to change notification settings - Fork 60.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows changes - Update generating-a-new-ssh-key-and-adding-it-to-th… #26069
Conversation
…e-ssh-agent.md Ensuring steps work in Windows and PowerShell
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@paulyuk Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
This is a gentle bump for the docs team that this PR is waiting for technical review. |
This comment was marked as spam.
This comment was marked as spam.
Hi @Vindawg138 , yes. Sticking to the original spirit of the article it shows you how to create your own SSH key, and then upload the public key to GH. The only issue is the steps did not work on Powershell like they did for Bash/ssh on linux. So this fixes the steps. |
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one question about when an elevated terminal is required, and when it isn't.
...ion/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent.md
Outdated
Show resolved
Hide resolved
...ion/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double checked on preview and looks good! ⚡. I'll go ahead and get this merged.
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
The current Windows pivot tab is all invalid showing bash/zsh steps.
This PR provides the working PowerShell commands.
I might need help ensuring the MarkDown renders correctly in the pivot tabs.
Ensuring steps work in Windows and PowerShell
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
data
directory.For content changes, I have completed the self-review checklist.