Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows changes - Update generating-a-new-ssh-key-and-adding-it-to-th… #26069

Merged
merged 7 commits into from
Oct 8, 2023

Conversation

paulyuk
Copy link
Contributor

@paulyuk paulyuk commented Jun 17, 2023

The current Windows pivot tab is all invalid showing bash/zsh steps.

This PR provides the working PowerShell commands.

I might need help ensuring the MarkDown renders correctly in the pivot tabs.

Ensuring steps work in Windows and PowerShell

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

…e-ssh-agent.md

Ensuring steps work in Windows and PowerShell
@welcome
Copy link

welcome bot commented Jun 17, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/connecting-to-github-with-ssh/generating-a-new-ssh-key-and-adding-it-to-the-ssh-agent.md fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae
fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@paulyuk Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review authentication Content relating to authentication and removed triage Do not begin working on this issue until triaged by the team labels Jun 19, 2023
@sophietheking sophietheking added the needs SME This proposal needs review from a subject matter expert label Jun 26, 2023
@github-actions
Copy link
Contributor

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

@github-actions
Copy link
Contributor

This is a gentle bump for the docs team that this PR is waiting for technical review.

@github-actions github-actions bot added the SME stale The request for an SME has staled label Jul 24, 2023
@cmwilson21 cmwilson21 removed the SME stale The request for an SME has staled label Jul 26, 2023
@Vindawg138

This comment was marked as spam.

@paulyuk
Copy link
Contributor Author

paulyuk commented Sep 4, 2023

Hi @Vindawg138 , yes. Sticking to the original spirit of the article it shows you how to create your own SSH key, and then upload the public key to GH. The only issue is the steps did not work on Powershell like they did for Bash/ssh on linux. So this fixes the steps.

@Vindawg138

This comment was marked as spam.

Copy link
Contributor

@vgrl vgrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question about when an elevated terminal is required, and when it isn't.

Copy link
Contributor

@vgrl vgrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked on preview and looks good! ⚡. I'll go ahead and get this merged.

@vgrl vgrl added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Oct 8, 2023
@vgrl vgrl enabled auto-merge October 8, 2023 22:03
@vgrl vgrl added this pull request to the merge queue Oct 8, 2023
Merged via the queue into github:main with commit c53bf5c Oct 8, 2023
30 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants