Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the example URL #2626

Merged
merged 3 commits into from
Jan 14, 2021
Merged

Correct the example URL #2626

merged 3 commits into from
Jan 14, 2021

Conversation

peternewman
Copy link
Contributor

@peternewman peternewman commented Jan 6, 2021

Why:

  • I'll make an issue if I really must, but it's adding four characters!
  • Without the .git it's not actually a git repository.

What's being changed:

See the diff, it's adding four characters! Diff slightly modified as it seems you can't show code markdown within code markdown.

diff --git a/content/github/using-git/adding-a-remote.md b/content/github/using-git/adding-a-remote.md
index ce69b353b00..65d792400a5 100644
--- a/content/github/using-git/adding-a-remote.md
+++ b/content/github/using-git/adding-a-remote.md
@@ -37,7 +37,7 @@ You may encounter these errors when trying to add a remote.
 This error means you've tried to add a remote with a name that already exists in your local repository:
 
  ``shell
-$ git remote add origin https://{% data variables.command_line.codeblock %}/octocat/Spoon-Knife
+$ git remote add origin https://{% data variables.command_line.codeblock %}/octocat/Spoon-Knife.git
 > fatal: remote origin already exists.
 ``

Without the .git it's not actually a git repository.

Check off the following:

@welcome
Copy link

welcome bot commented Jan 6, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

@peternewman Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request to answer Why and What's being changed, then we'll get this up for review!

@peternewman
Copy link
Contributor Author

@peternewman Thanks for opening a PR +1 Please fill out the pull request template in the top comment in this pull request to answer Why and What's being changed, then we'll get this up for review!

I've added more why and what's changed detail if someone can re-review please.

Do you actually require me to create a related issue for something so trivial?

@janiceilene
Copy link
Contributor

Thanks so much for the additional context @peternewman! I agree that an issue isn't necessary for this particular fix. I'll get this triaged for review ⚡

@janiceilene janiceilene added the content This issue or pull request belongs to the Docs Content team label Jan 11, 2021
@shati-patel shati-patel self-assigned this Jan 13, 2021
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, @peternewman! Your help with tidying up our documentation is much appreciated ✨

We've briefly paused merging to main, but I'll label your PR as "ready". We'll merge it as soon as we can!

@shati-patel shati-patel added the ready to merge This pull request is ready to merge label Jan 13, 2021
@shati-patel shati-patel merged commit 1aebff4 into github:main Jan 14, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@peternewman
Copy link
Contributor Author

Thanks @shati-patel , I assumed you meant a week of delay or something not just a day or two!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants