-
Notifications
You must be signed in to change notification settings - Fork 60.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the example URL #2626
Correct the example URL #2626
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@peternewman Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request to answer Why and What's being changed, then we'll get this up for review! |
I've added more why and what's changed detail if someone can re-review please. Do you actually require me to create a related issue for something so trivial? |
Thanks so much for the additional context @peternewman! I agree that an issue isn't necessary for this particular fix. I'll get this triaged for review ⚡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix, @peternewman! Your help with tidying up our documentation is much appreciated ✨
We've briefly paused merging to main
, but I'll label your PR as "ready". We'll merge it as soon as we can!
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
Thanks @shati-patel , I assumed you meant a week of delay or something not just a day or two! |
Why:
What's being changed:
See the diff, it's adding four characters! Diff slightly modified as it seems you can't show code markdown within code markdown.
Without the .git it's not actually a git repository.
Check off the following: