Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release_properties.md #27059

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

sandormatyas
Copy link
Contributor

@sandormatyas sandormatyas commented Jul 25, 2023

Why:

Currently on the GitHub event types page under the ReleaseEvent part there is a hyperlink on the word "release" that points to the REST API / Repositories page. This should be pointing to the Releases part of the documentation instead.

Closes: #27058

What's being changed (if available, include any code snippets, screenshots, or gifs):

The only change in this PR is the path for the hyperlink to point to the page I believe it should be pointing to: REST API / Releases.

In my local environment it successfully redirected to the page.
image

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Jul 25, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 25, 2023
@cmwilson21
Copy link
Contributor

@sandormatyas Thank you for opening an issue and submitting a PR! I've edited your post to link your PR to your issue. 👍

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review webhooks Content related to webhooks and removed triage Do not begin working on this issue until triaged by the team labels Jul 26, 2023
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this! We'll get this merged down for you.

@skedwards88 skedwards88 added this pull request to the merge queue Jul 26, 2023
@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Jul 26, 2023
Merged via the queue into github:main with commit 232c6e1 Jul 26, 2023
67 of 68 checks passed
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review webhooks Content related to webhooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hyperlink on GitHub event types page points to incorrect resource
3 participants