-
Notifications
You must be signed in to change notification settings - Fork 60.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applying lossless compression to unoptimized png files in images #299
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏🏼 Thanks!
If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨ |
Thanks, I'll do that. I don't really know what kind of contribution that is, though ? Is that content ? Tell me if you see somethiing more appropriate. @all-contributors please add @Protectator for content |
This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token ] in JSON at position 8560 |
Indeed, this ain't normal : https://github.com/github/docs/blob/main/.all-contributorsrc#L331 |
I made a PR to repair the file first, I'll add myself after that : #391 |
@all-contributors please add @Protectator for content |
I've put up a pull request to add @Protectator! 🎉 |
Why:
This PR aims to solve #298.
What's being changed:
I optimized the size of PNGs in the
assets/images
by using lossless compression algorithm on them. The new size of the optimized PNGs in this PR vary between 49% and 93% of their original size. This PR reduces the total size of the images by ~2457 KB.Check off the following: