Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuring-the-referrer-policy-for-your-enterprise.md #30177

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

sgarciajaramillo
Copy link
Contributor

@sgarciajaramillo sgarciajaramillo commented Nov 25, 2023

Why:

There is a step missing to find where the USer Agent Referrer Policy setting is loacted.

Closes:
N/A

What's being changed (if available, include any code snippets, screenshots, or gifs):

Adding additional step to get into the Authentication security section where this setting is located

Setting location on GHES 3.10.3
image

Before
image

After
image

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Adding additional step to get into the Authentication security section where this setting is located
Copy link

welcome bot commented Nov 25, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 25, 2023
Copy link
Contributor

github-actions bot commented Nov 25, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
admin/configuration/hardening-security-for-your-enterprise/configuring-the-referrer-policy-for-your-enterprise.md ghes@ 3.11 3.10 3.9 3.8 3.7
ghes@ 3.11 3.10 3.9 3.8 3.7

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

prechayimmee

This comment was marked as spam.

@janiceilene
Copy link
Contributor

@sgarciajaramillo Thanks so much for opening a PR! I'll get this triaged for review ✨

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Nov 27, 2023
@CASABECI

This comment was marked as spam.

rolandtmz814

This comment was marked as spam.

@@ -34,5 +34,6 @@ You can enable the `same-origin` referrer policy to instruct modern browsers to

{% data reusables.enterprise-accounts.access-enterprise %}
{% data reusables.enterprise-accounts.settings-tab %}

This comment was marked as spam.

mattpollard
mattpollard previously approved these changes Dec 12, 2023
Copy link
Contributor

@mattpollard mattpollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sgarciajaramillo ⚡ I've verified that this is correct for GHES 3.7+. I'll incorporate a small revision, and then publish the change.

@mattpollard mattpollard added this pull request to the merge queue Dec 12, 2023
Merged via the queue into github:main with commit bcbef8d Dec 12, 2023
42 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants